Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix mean pooling function

ozanarmagan36c717b72ac4
diff --git a/include/text_embedder.h b/include/text_embedder.h
index 370d0670..dd6a225f 100644
--- a/include/text_embedder.h
+++ b/include/text_embedder.h
@@ -33,7 +33,7 @@ class TextEmbedder {
std::unique_ptr<TextEmbeddingTokenizer> tokenizer_;
std::unique_ptr<RemoteEmbedder> remote_embedder_;
std::string vocab_file_name;
- static std::vector<float> mean_pooling(const std::vector<std::vector<float>>& input);
+ static std::vector<float> mean_pooling(const std::vector<std::vector<float>>& input, const std::vector<int64_t>& attention_mask);
std::string output_tensor_name;
size_t num_dim;
std::mutex mutex_;
diff --git a/src/text_embedder.cpp b/src/text_embedder.cpp
index 897b1c0b..0e464792 100644
--- a/src/text_embedder.cpp
+++ b/src/text_embedder.cpp
@@ -84,16 +84,28 @@ TextEmbedder::TextEmbedder(const nlohmann::json& model_config, size_t num_dims)
}
-std::vector<float> TextEmbedder::mean_pooling(const std::vector<std::vector<float>>& inputs) {
+std::vector<float> TextEmbedder::mean_pooling(const std::vector<std::vector<float>>& inputs, const std::vector<int64_t>& attention_mask) {
std::vector<float> pooled_output;
for (int i = 0; i < inputs[0].size(); i++) {
float sum = 0;
for (int j = 0; j < inputs.size(); j++) {
- sum += inputs[j][i];
+ sum += inputs[j][i] * attention_mask[j];
}
- pooled_output.push_back(sum / inputs.size());
+ pooled_output.push_back(sum);
}
+
+ // get sum of attention mask
+ float sum_attention_mask = 0;
+ for(auto& val : attention_mask) {
+ sum_attention_mask += val;
+ }
+
+ // divide by sum of attention mask
+ for(auto& val : pooled_output) {
+ val /= sum_attention_mask;
+ }
+
return pooled_output;
}
@@ -146,8 +158,7 @@ embedding_res_t TextEmbedder::Embed(const std::string& text, const size_t remote
}
output.push_back(temp);
}
- auto pooled_output = mean_pooling(output);
-
+ auto pooled_output = mean_pooling(output, encoded_input.attention_mask);
return embedding_res_t(pooled_output);
}
}
@@ -232,7 +243,7 @@ std::vector<embedding_res_t> TextEmbedder::batch_embed(const std::vector<std::st
}
output.push_back(output_row);
}
- outputs.push_back(embedding_res_t(mean_pooling(output)));
+ outputs.push_back(embedding_res_t(mean_pooling(output, encoded_inputs.attention_mask[i])));
}
}
} else {