Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Parse nested join.

Harpreet Sangar3a510ccde506
diff --git a/src/collection_manager.cpp b/src/collection_manager.cpp
index 3939162f..9f407d3c 100644
--- a/src/collection_manager.cpp
+++ b/src/collection_manager.cpp
@@ -951,6 +951,10 @@ void CollectionManager::_get_reference_collection_names(const std::string& filte
reference_collection_names.clear();
return;
}
+
+ // Need to process the filter expression inside parenthesis in case of nested join.
+ auto sub_filter_query = filter_query.substr(open_paren_pos + 1, i - open_paren_pos - 2);
+ _get_reference_collection_names(sub_filter_query, reference_collection_names);
} else {
while (i + 1 < size && filter_query[++i] != ':');
if (i >= size) {
diff --git a/test/collection_manager_test.cpp b/test/collection_manager_test.cpp
index e5f62ff0..1bf90dfd 100644
--- a/test/collection_manager_test.cpp
+++ b/test/collection_manager_test.cpp
@@ -1425,6 +1425,15 @@ TEST_F(CollectionManagerTest, GetReferenceCollectionNames) {
ASSERT_EQ(1, reference_collection_names.count(item));
}
reference_collection_names.clear();
+
+ filter_query = "$product_variants( $inventory($retailers(location:(33.865,-118.375,100 km))))";
+ result = {"product_variants", "inventory", "retailers"};
+ CollectionManager::_get_reference_collection_names(filter_query, reference_collection_names);
+ ASSERT_EQ(3, reference_collection_names.size());
+ for (const auto &item: result) {
+ ASSERT_EQ(1, reference_collection_names.count(item));
+ }
+ reference_collection_names.clear();
}
TEST_F(CollectionManagerTest, ReferencedInBacklog) {