Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Add `filter_result_iterator_t::get_n_ids`. Use `is_valid` instead of `valid()`. Handle special `_all_` field name in filtering logic.

Harpreet Sangar5587c3762360
diff --git a/include/filter_result_iterator.h b/include/filter_result_iterator.h
index 006d0823..d0179402 100644
--- a/include/filter_result_iterator.h
+++ b/include/filter_result_iterator.h
@@ -131,15 +131,10 @@ private:
explicit filter_result_iterator_t(uint32_t approx_filter_ids_length);
-public:
- uint32_t* get_ids() {
- return filter_result.docs;
- }
-
- uint32_t get_length() {
- return filter_result.count;
- }
+ /// Returns true when doc and reference hold valid values. Used in conjunction with next() and skip_to(id).
+ [[nodiscard]] bool valid();
+public:
uint32_t seq_id = 0;
/// Collection name -> references
std::map<std::string, reference_filter_result_t> reference;
diff --git a/src/filter_result_iterator.cpp b/src/filter_result_iterator.cpp
index ff9cab1a..a6b61134 100644
--- a/src/filter_result_iterator.cpp
+++ b/src/filter_result_iterator.cpp
@@ -447,16 +447,7 @@ void filter_result_iterator_t::next() {
field f = index->search_schema.at(a_filter.field_name);
- if (f.is_integer() || f.is_float() || f.is_bool()) {
- result_index++;
- if (result_index >= filter_result.count) {
- is_valid = false;
- return;
- }
-
- seq_id = filter_result.docs[result_index];
- return;
- } else if (f.is_string()) {
+ if (f.is_string()) {
if (filter_node->filter_exp.apply_not_equals) {
if (++seq_id < result_index) {
return;
@@ -996,17 +987,7 @@ void filter_result_iterator_t::skip_to(uint32_t id) {
field f = index->search_schema.at(a_filter.field_name);
- if (f.is_integer() || f.is_float() || f.is_bool()) {
- while(result_index < filter_result.count && filter_result.docs[result_index] < id) {
- result_index++;
- }
-
- if (result_index >= filter_result.count) {
- is_valid = false;
- }
-
- return;
- } else if (f.is_string()) {
+ if (f.is_string()) {
if (filter_node->filter_exp.apply_not_equals) {
if (id < seq_id) {
return;