Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix `compute_iterators` not initializing `reference`. (#1963)

Harpreet Sangar5c538494128e
diff --git a/src/filter_result_iterator.cpp b/src/filter_result_iterator.cpp
index 7b4939cc..336b32b5 100644
--- a/src/filter_result_iterator.cpp
+++ b/src/filter_result_iterator.cpp
@@ -2464,6 +2464,12 @@ void filter_result_iterator_t::compute_iterators() {
result_index = 0;
seq_id = filter_result.docs[result_index];
approx_filter_ids_length = filter_result.count;
+
+ if (filter_result.coll_to_references != nullptr) {
+ for (const auto& ref_result: filter_result.coll_to_references[result_index]) {
+ reference.insert(ref_result);
+ }
+ }
}
is_filter_result_initialized = true;
diff --git a/test/core_api_utils_test.cpp b/test/core_api_utils_test.cpp
index 201de550..323208b4 100644
--- a/test/core_api_utils_test.cpp
+++ b/test/core_api_utils_test.cpp
@@ -1056,6 +1056,30 @@ TEST_F(CoreAPIUtilsTest, ExportWithJoin) {
ASSERT_EQ(5, doc["Customers"].size());
ASSERT_EQ(1, doc["Customers"].count("product_price"));
ASSERT_EQ(73.5, doc["Customers"]["product_price"]);
+
+ delete dynamic_cast<export_state_t*>(req->data);
+ req->data = nullptr;
+ res->body.clear();
+ req->params["filter_by"] = "rating: >2 && (id:* || $Customers(id:*))";
+ req->params["include_fields"] = "$Customers(*,strategy:nest_array) as Customers";
+
+ get_export_documents(req, res);
+
+ res_strs.clear();
+ StringUtils::split(res->body, res_strs, "\n");
+
+ doc = nlohmann::json::parse(res_strs[0]);
+ ASSERT_EQ(6, doc.size());
+ ASSERT_EQ(1, doc.count("product_name"));
+ ASSERT_EQ("soap", doc["product_name"]);
+ ASSERT_EQ(1, doc.count("Customers"));
+ ASSERT_EQ(2, doc["Customers"].size());
+ ASSERT_EQ(5, doc["Customers"][0].size());
+ ASSERT_EQ("customer_a", doc["Customers"][0]["customer_id"]);
+ ASSERT_EQ(73.5, doc["Customers"][0]["product_price"]);
+ ASSERT_EQ(5, doc["Customers"][1].size());
+ ASSERT_EQ("customer_b", doc["Customers"][1]["customer_id"]);
+ ASSERT_EQ(140, doc["Customers"][1]["product_price"]);
}
TEST_F(CoreAPIUtilsTest, TestParseAPIKeyIPFromMetadata) {