Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix invalid read.

Harpreet Sangar665eee9b0315
diff --git a/include/field.h b/include/field.h
index 776481d2..18a1d4b7 100644
--- a/include/field.h
+++ b/include/field.h
@@ -648,6 +648,20 @@ struct filter_result_t {
filter_result_t(uint32_t count, uint32_t* docs) : count(count), docs(docs) {}
+ filter_result_t& operator=(filter_result_t&& obj) noexcept {
+ if (&obj == this)
+ return *this;
+
+ count = obj.count;
+ docs = obj.docs;
+ reference_filter_results = std::map(obj.reference_filter_results);
+
+ obj.docs = nullptr;
+ obj.reference_filter_results.clear();
+
+ return *this;
+ }
+
~filter_result_t() {
delete[] docs;
for (const auto &item: reference_filter_results) {
diff --git a/src/index.cpp b/src/index.cpp
index 0891968f..f9ba9f35 100644
--- a/src/index.cpp
+++ b/src/index.cpp
@@ -1546,7 +1546,7 @@ Option<bool> Index::do_filtering(filter_node_t* const root,
return Option(true);
}
- result = reference_filter_result;
+ result = std::move(reference_filter_result);
return Option(true);
}