Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix facet index unit tests.

Kishore Nallan6a17b454ccce
diff --git a/test/facet_index_test.cpp b/test/facet_index_test.cpp
index 1c141388..4da5060c 100644
--- a/test/facet_index_test.cpp
+++ b/test/facet_index_test.cpp
@@ -3,6 +3,8 @@
TEST(FacetIndexTest, FacetValueDeletionString) {
facet_index_t findex;
+ findex.initialize("brand");
+
std::unordered_map<facet_value_id_t, std::vector<uint32_t>, facet_value_id_t::Hash> fvalue_to_seq_ids;
std::unordered_map<uint32_t, std::vector<facet_value_id_t>> seq_id_to_fvalues;
@@ -18,15 +20,54 @@ TEST(FacetIndexTest, FacetValueDeletionString) {
doc["brand"] = "nike";
findex.insert("brand", fvalue_to_seq_ids, seq_id_to_fvalues, true);
+ ASSERT_EQ(3, findex.facet_val_num_ids("brand", "nike"));
+
findex.remove(doc, brandf, 0);
findex.remove(doc, brandf, 1);
- findex.remove(doc, brandf, 2);
+ ASSERT_EQ(1, findex.facet_val_num_ids("brand", "nike"));
+ findex.remove(doc, brandf, 2);
ASSERT_FALSE(findex.facet_value_exists("brand", "nike"));
}
+TEST(FacetIndexTest, FacetValueDeletionOfLongString) {
+ facet_index_t findex;
+ findex.initialize("brand");
+
+ std::unordered_map<facet_value_id_t, std::vector<uint32_t>, facet_value_id_t::Hash> fvalue_to_seq_ids;
+ std::unordered_map<uint32_t, std::vector<facet_value_id_t>> seq_id_to_fvalues;
+
+ std::string longval;
+
+ for(size_t i = 0; i < 200; i++) {
+ longval += "a";
+ }
+
+ facet_value_id_t longfval(longval, 1);
+
+ fvalue_to_seq_ids[longfval] = {0, 1, 2};
+ seq_id_to_fvalues[0] = {longfval};
+ seq_id_to_fvalues[1] = {longfval};
+ seq_id_to_fvalues[2] = {longfval};
+
+ field brandf("brand", field_types::STRING, true);
+ nlohmann::json doc;
+ doc["brand"] = longval;
+
+ findex.insert("brand", fvalue_to_seq_ids, seq_id_to_fvalues, true);
+ ASSERT_EQ(3, findex.facet_val_num_ids("brand", longval));
+
+ findex.remove(doc, brandf, 0);
+ findex.remove(doc, brandf, 1);
+ ASSERT_EQ(1, findex.facet_val_num_ids("brand", longval));
+
+ findex.remove(doc, brandf, 2);
+ ASSERT_FALSE(findex.facet_value_exists("brand", longval));
+}
+
TEST(FacetIndexTest, FacetValueDeletionFloat) {
facet_index_t findex;
+ findex.initialize("price");
std::unordered_map<facet_value_id_t, std::vector<uint32_t>, facet_value_id_t::Hash> fvalue_to_seq_ids;
std::unordered_map<uint32_t, std::vector<facet_value_id_t>> seq_id_to_fvalues;
@@ -39,13 +80,16 @@ TEST(FacetIndexTest, FacetValueDeletionFloat) {
field pricef("price", field_types::FLOAT, true);
nlohmann::json doc;
- doc["price"] = "99.95";
+ doc["price"] = 99.95;
+
+ findex.insert("price", fvalue_to_seq_ids, seq_id_to_fvalues, true);
+ ASSERT_EQ(3, findex.facet_val_num_ids("price", "99.95"));
- findex.insert("brand", fvalue_to_seq_ids, seq_id_to_fvalues, true);
findex.remove(doc, pricef, 0);
findex.remove(doc, pricef, 1);
- findex.remove(doc, pricef, 2);
+ ASSERT_EQ(1, findex.facet_val_num_ids("price", "99.95"));
+ findex.remove(doc, pricef, 2);
ASSERT_FALSE(findex.facet_value_exists("price", "99.95"));
}