Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences
C++ algoliadatastoreelasticsearchenterprise-searchfacetingfull-text-searchfuzzy-searchgeosearchin-memoryinstantsearchmerchandisingpineconesearchsearch-enginesemantic-searchsimilarity-searchsite-searchsynonymstypo-tolerancevector-search
Fix non-schema fields not being exported.
Kishore Nallan6d14136ae5a6
diff --git a/src/core_api.cpp b/src/core_api.cppindex 89d5de80..5f78da13 100644--- a/src/core_api.cpp+++ b/src/core_api.cpp@@ -1094,10 +1094,6 @@ bool get_export_documents(const std::shared_ptr<http_req>& req, const std::sharereturn false;}- if (include_fields_vec.empty()) {- include_fields_vec.emplace_back("*");- }-include_fields.insert(include_fields_vec.begin(), include_fields_vec.end());exclude_fields.insert(exclude_fields_vec.begin(), exclude_fields_vec.end());diff --git a/test/core_api_utils_test.cpp b/test/core_api_utils_test.cppindex 3376a4c5..3cadd548 100644--- a/test/core_api_utils_test.cpp+++ b/test/core_api_utils_test.cpp@@ -1086,7 +1086,8 @@ TEST_F(CoreAPIUtilsTest, ExportIncludeExcludeFields) {auto doc1 = R"({"name": {"first": "John", "last": "Smith"},- "points": 100+ "points": 100,+ "description": "description"})"_json;auto add_op = coll1->add(doc1.dump(), CREATE);@@ -1121,11 +1122,32 @@ TEST_F(CoreAPIUtilsTest, ExportIncludeExcludeFields) {res_strs.clear();StringUtils::split(res->body, res_strs, "\n");doc = nlohmann::json::parse(res_strs[0]);- ASSERT_EQ(3, doc.size());+ ASSERT_EQ(4, doc.size());+ ASSERT_EQ(1, doc.count("id"));+ ASSERT_EQ(1, doc.count("points"));+ ASSERT_EQ(1, doc.count("name"));+ ASSERT_EQ(1, doc["name"].count("first"));+ ASSERT_EQ(1, doc.count("description")); // field not in schema is exported++ // no include or exclude fields++ delete dynamic_cast<export_state_t*>(req->data);+ req->data = nullptr;+ res->body.clear();+ req->params.erase("include_fields");+ req->params.erase("exclude_fields");+ get_export_documents(req, res);++ res_strs.clear();+ StringUtils::split(res->body, res_strs, "\n");+ doc = nlohmann::json::parse(res_strs[0]);+ ASSERT_EQ(4, doc.size());ASSERT_EQ(1, doc.count("id"));ASSERT_EQ(1, doc.count("points"));ASSERT_EQ(1, doc.count("name"));ASSERT_EQ(1, doc["name"].count("first"));+ ASSERT_EQ(1, doc["name"].count("last"));+ ASSERT_EQ(1, doc.count("description")); // field not in schema is exportedcollectionManager.drop_collection("coll1");}