Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

More tests for query string parsing.

kishorenc6fa6fd9258e7
diff --git a/src/string_utils.cpp b/src/string_utils.cpp
index 6fdba799..37d3685d 100644
--- a/src/string_utils.cpp
+++ b/src/string_utils.cpp
@@ -141,17 +141,17 @@ std::map<std::string, std::string> StringUtils::parse_query_string(const std::st
if(start_of_new_param || end_of_params) {
// Save accumulated key_value
+ if(end_of_params && query[i] != '&') {
+ key_value += query[i];
+ }
+
size_t j = 0;
bool iterating_on_key = true;
std::string key;
std::string value;
- if(end_of_params && query[i] != '&') {
- key_value += query[i];
- }
-
while(j < key_value.size()) {
- if(key_value[j] == '=') {
+ if(key_value[j] == '=' && iterating_on_key) {
iterating_on_key = false;
} else if(iterating_on_key) {
key += key_value[j];
diff --git a/test/string_utils_test.cpp b/test/string_utils_test.cpp
index d9851d12..817d72d7 100644
--- a/test/string_utils_test.cpp
+++ b/test/string_utils_test.cpp
@@ -166,6 +166,19 @@ TEST(StringUtilsTest, ShouldParseQueryString) {
ASSERT_EQ("bar", qmap["q"]);
ASSERT_EQ("", qmap["filter_by"]);
+ qs = "q=bread && breakfast&filter_by=";
+ qmap = StringUtils::parse_query_string(qs);
+ ASSERT_EQ(2, qmap.size());
+ ASSERT_EQ("bread && breakfast", qmap["q"]);
+ ASSERT_EQ("", qmap["filter_by"]);
+
+ qs = "q=bread & breakfast&filter_by=";
+ qmap = StringUtils::parse_query_string(qs);
+ ASSERT_EQ(3, qmap.size());
+ ASSERT_EQ("bread ", qmap["q"]);
+ ASSERT_EQ("", qmap[" breakfast"]);
+ ASSERT_EQ("", qmap["filter_by"]);
+
qs = "q=bar&filter_by=&";
qmap = StringUtils::parse_query_string(qs);
ASSERT_EQ(2, qmap.size());
@@ -190,6 +203,24 @@ TEST(StringUtilsTest, ShouldParseQueryString) {
ASSERT_EQ("", qmap["baz"]);
ASSERT_EQ("true", qmap["bazinga"]);
+ qs = "foo=bar&bazinga=true&foo=buzz";
+ qmap = StringUtils::parse_query_string(qs);
+ ASSERT_EQ(2, qmap.size());
+ ASSERT_EQ("buzz", qmap["foo"]);
+ ASSERT_EQ("true", qmap["bazinga"]);
+
+ qs = "filter_by=points:>100&bazinga=true&filter_by=points:<=200";
+ qmap = StringUtils::parse_query_string(qs);
+ ASSERT_EQ(2, qmap.size());
+ ASSERT_EQ("points:>100&&points:<=200", qmap["filter_by"]);
+ ASSERT_EQ("true", qmap["bazinga"]);
+
+ qs = "filter_by=points:>100 && brand:= nike&bazinga=true&filter_by=points:<=200";
+ qmap = StringUtils::parse_query_string(qs);
+ ASSERT_EQ(2, qmap.size());
+ ASSERT_EQ("points:>100 && brand:= nike&&points:<=200", qmap["filter_by"]);
+ ASSERT_EQ("true", qmap["bazinga"]);
+
qs = "foo";
qmap = StringUtils::parse_query_string(qs);
ASSERT_EQ(1, qmap.size());