Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Use const auto&

ozanarmagan73ae433ab559
diff --git a/src/collection.cpp b/src/collection.cpp
index 31b7cc34..adda2fc5 100644
--- a/src/collection.cpp
+++ b/src/collection.cpp
@@ -3797,8 +3797,8 @@ Option<bool> Collection::batch_alter_data(const std::vector<field>& alter_fields
if(f.embed.count(fields::from) != 0) {
found_embedding_field = true;
- auto text_embedders = TextEmbedderManager::get_instance()._get_text_embedders();
- auto model_name = f.embed[fields::model_config][fields::model_name].get<std::string>();
+ const auto& text_embedders = TextEmbedderManager::get_instance()._get_text_embedders();
+ const auto& model_name = f.embed[fields::model_config][fields::model_name].get<std::string>();
if(text_embedders.count(model_name) == 0) {
size_t dummy_num_dim = 0;
auto validate_model_res = TextEmbedderManager::get_instance().validate_and_init_model(f.embed[fields::model_config], dummy_num_dim);
diff --git a/src/collection_manager.cpp b/src/collection_manager.cpp
index 389d546f..6a3e8492 100644
--- a/src/collection_manager.cpp
+++ b/src/collection_manager.cpp
@@ -1567,7 +1567,6 @@ Option<Collection*> CollectionManager::clone_collection(const string& existing_n
void CollectionManager::process_embedding_field_delete(const std::string& model_name) {
// can't have a shared lock here
// because we will be already acquiring a lock on collection manager if we are deleting a collection
- //std::shared_lock lock(mutex);
bool found = false;
for(const auto& collection: collections) {