Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences
C++ algoliadatastoreelasticsearchenterprise-searchfacetingfull-text-searchfuzzy-searchgeosearchin-memoryinstantsearchmerchandisingpineconesearchsearch-enginesemantic-searchsimilarity-searchsite-searchsynonymstypo-tolerancevector-search
Fix preset restoration.
Kishore Nallan7d4466c93794
diff --git a/src/collection_manager.cpp b/src/collection_manager.cppindex e05ee9ca..fd81ae55 100644--- a/src/collection_manager.cpp+++ b/src/collection_manager.cpp@@ -261,8 +261,15 @@ Option<bool> CollectionManager::load(const size_t collection_batch_size, const siter = store->scan(preset_prefix_key, &preset_upper_bound);while(iter->Valid() && iter->key().starts_with(preset_prefix_key)) {std::vector<std::string> parts;- StringUtils::split(iter->key().ToString(), parts, preset_prefix_key);- preset_configs[parts[0]] = iter->value().ToString();+ std::string preset_name = iter->key().ToString().substr(preset_prefix_key.size());+ nlohmann::json preset_obj = nlohmann::json::parse(iter->value().ToString(), nullptr, false);++ if(!preset_obj.is_discarded() && preset_obj.is_object()) {+ preset_configs[preset_name] = preset_obj;+ } else {+ LOG(INFO) << "Invalid value for preset " << preset_name;+ }+iter->Next();}diff --git a/test/collection_manager_test.cpp b/test/collection_manager_test.cppindex 75a1c77c..747c4171 100644--- a/test/collection_manager_test.cpp+++ b/test/collection_manager_test.cpp@@ -660,6 +660,32 @@ TEST_F(CollectionManagerTest, RestoreAutoSchemaDocsOnRestart) {collectionManager2.drop_collection("coll1");}+TEST_F(CollectionManagerTest, RestorePresetsOnRestart) {+ auto preset_value = R"(+ {"q":"*", "per_page": "12"}+ )"_json;++ collectionManager.upsert_preset("single_preset", preset_value);++ // create a new collection manager to ensure that it restores the records from the disk backed store+ CollectionManager& collectionManager2 = CollectionManager::get_instance();+ collectionManager2.init(store, 1.0, "auth_key", quit);+ auto load_op = collectionManager2.load(8, 1000);++ if(!load_op.ok()) {+ LOG(ERROR) << load_op.error();+ }++ ASSERT_TRUE(load_op.ok());++ nlohmann::json preset;+ collectionManager2.get_preset("single_preset", preset);+ ASSERT_EQ("*", preset["q"].get<std::string>());++ collectionManager.drop_collection("coll1");+ collectionManager2.drop_collection("coll1");+}+TEST_F(CollectionManagerTest, RestoreNestedDocsOnRestart) {nlohmann::json schema = R"({"name": "coll1",