Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix numeric filter performance regression. (#1749)

Harpreet Sangar85c5c80445a4
diff --git a/src/filter_result_iterator.cpp b/src/filter_result_iterator.cpp
index 39cb0bcf..df21fd65 100644
--- a/src/filter_result_iterator.cpp
+++ b/src/filter_result_iterator.cpp
@@ -2409,35 +2409,35 @@ void filter_result_iterator_t::compute_iterators() {
std::vector<uint32_t> f_id_buff;
for (uint32_t i = 0; i < id_lists.size(); i++) {
- auto& lists = id_lists[i];
- for (const auto& list: lists) {
- if (numerical_not_iterator_index.count(i) == 0) {
- list->uncompress(f_id_buff);
- continue;
- }
+ auto const& lists = id_lists[i];
+ auto const& is_not_equals_comparator = numerical_not_iterator_index.count(i) != 0;
- // NOT_EQUALS comparator
- std::vector<uint32_t> equals_ids;
- list->uncompress(equals_ids);
+ for (const auto& list: lists) {
+ if (is_not_equals_comparator) {
+ std::vector<uint32_t> equals_ids;
+ list->uncompress(equals_ids);
- uint32_t* not_equals_ids = nullptr;
- auto const not_equals_ids_len = ArrayUtils::exclude_scalar(index->seq_ids->uncompress(), index->seq_ids->num_ids(),
- &equals_ids[0], equals_ids.size(),
- &not_equals_ids);
+ uint32_t* not_equals_ids = nullptr;
+ auto const not_equals_ids_len = ArrayUtils::exclude_scalar(index->seq_ids->uncompress(), index->seq_ids->num_ids(),
+ &equals_ids[0], equals_ids.size(),
+ &not_equals_ids);
- std::copy(not_equals_ids, not_equals_ids + not_equals_ids_len, std::back_inserter(f_id_buff));
- }
+ std::copy(not_equals_ids, not_equals_ids + not_equals_ids_len, std::back_inserter(f_id_buff));
+ } else {
+ list->uncompress(f_id_buff);
+ }
- if (f_id_buff.size() >= 100'000) {
- gfx::timsort(f_id_buff.begin(), f_id_buff.end());
- f_id_buff.erase(std::unique( f_id_buff.begin(), f_id_buff.end() ), f_id_buff.end());
+ if (f_id_buff.size() >= 100'000) {
+ gfx::timsort(f_id_buff.begin(), f_id_buff.end());
+ f_id_buff.erase(std::unique( f_id_buff.begin(), f_id_buff.end() ), f_id_buff.end());
- uint32_t* out = nullptr;
- filter_ids_len = ArrayUtils::or_scalar(filter_ids, filter_ids_len, f_id_buff.data(), f_id_buff.size(),
- &out);
- delete[] filter_ids;
- filter_ids = out;
- std::vector<uint32_t>().swap(f_id_buff); // clears out memory
+ uint32_t* out = nullptr;
+ filter_ids_len = ArrayUtils::or_scalar(filter_ids, filter_ids_len, f_id_buff.data(), f_id_buff.size(),
+ &out);
+ delete[] filter_ids;
+ filter_ids = out;
+ std::vector<uint32_t>().swap(f_id_buff); // clears out memory
+ }
}
}