Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix initialization of priority queue.

Kishore Nallan874b5beb898d
diff --git a/src/art.cpp b/src/art.cpp
index fc515ca5..80a0cd28 100644
--- a/src/art.cpp
+++ b/src/art.cpp
@@ -905,7 +905,8 @@ int art_topk_iter(const art_node *root, token_ordering token_order, size_t max_r
std::vector<art_leaf *> &results) {
printf("INSIDE art_topk_iter: root->type: %d\n", root->type);
- std::priority_queue<art_node *, std::vector<const art_node *>, decltype(&compare_art_node_score_pq)> q;
+ std::priority_queue<art_node *, std::vector<const art_node *>,
+ decltype(&compare_art_node_score_pq)> q(compare_art_node_score_pq);
if(token_order == FREQUENCY) {
q = std::priority_queue<art_node *, std::vector<const art_node *>,
diff --git a/test/collection_test.cpp b/test/collection_test.cpp
index 6ab46195..5e4ccbd1 100644
--- a/test/collection_test.cpp
+++ b/test/collection_test.cpp
@@ -207,6 +207,10 @@ TEST_F(CollectionTest, SkipUnindexedTokensDuringPhraseSearch) {
}
// should not try to drop tokens to expand query
+ results.clear();
+ results = collection->search("the a", query_fields, "", facets, sort_fields, 0, 10, 1, FREQUENCY, false, 10).get();
+ ASSERT_EQ(8, results["hits"].size());
+
results.clear();
results = collection->search("the a", query_fields, "", facets, sort_fields, 0, 10, 1, FREQUENCY, false, 0).get();
ASSERT_EQ(3, results["hits"].size());
@@ -219,6 +223,7 @@ TEST_F(CollectionTest, SkipUnindexedTokensDuringPhraseSearch) {
ASSERT_STREQ(id.c_str(), result_id.c_str());
}
+ // with no indexed word
results.clear();
results = collection->search("DoesNotExist1 DoesNotExist2", query_fields, "", facets, sort_fields, 0, 10).get();
ASSERT_EQ(0, results["hits"].size());