Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix locking for analytics rule deletion.

Kishore Nallan8ad97e73a004
diff --git a/src/analytics_manager.cpp b/src/analytics_manager.cpp
index 91f92942..225101cc 100644
--- a/src/analytics_manager.cpp
+++ b/src/analytics_manager.cpp
@@ -147,8 +147,7 @@ Option<bool> AnalyticsManager::remove_rule(const string &name) {
}
Option<bool> AnalyticsManager::remove_popular_queries_index(const std::string &name) {
- std::unique_lock lock(mutex);
-
+ // lock is held by caller
auto suggestion_configs_it = suggestion_configs.find(name);
if(suggestion_configs_it == suggestion_configs.end()) {