Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

More tests.

kishorenc933cbe9bb050
diff --git a/cmake/Glog.cmake b/cmake/Glog.cmake
new file mode 100644
index 00000000..e69de29b
diff --git a/src/collection.cpp b/src/collection.cpp
index 1c244855..fbe0a376 100644
--- a/src/collection.cpp
+++ b/src/collection.cpp
@@ -390,6 +390,10 @@ Option<nlohmann::json> Collection::search(const std::string & query, const std::
const std::vector<std::string>& group_by_fields,
const size_t group_limit) {
+ if(query != "*" && search_fields.empty()) {
+ return Option<nlohmann::json>(400, "No search fields specified for the query.");
+ }
+
std::vector<uint32_t> excluded_ids;
std::map<size_t, std::vector<uint32_t>> include_ids; // position => list of IDs
populate_overrides(query, pinned_hits, hidden_hits, include_ids, excluded_ids);
diff --git a/src/core_api.cpp b/src/core_api.cpp
index 03f89a2f..a52b1a7a 100644
--- a/src/core_api.cpp
+++ b/src/core_api.cpp
@@ -252,11 +252,6 @@ bool get_search(http_req & req, http_res & res) {
return false;
}
- if(req.params.count(QUERY_BY) == 0 && req.params[QUERY] != "*") {
- res.set_400(std::string("Parameter `") + QUERY_BY + "` is required.");
- return false;
- }
-
if(req.params.count(MAX_FACET_VALUES) == 0) {
req.params[MAX_FACET_VALUES] = "10";
}
diff --git a/test/collection_grouping_test.cpp b/test/collection_grouping_test.cpp
index f3e0e6a2..b1fcd8b6 100644
--- a/test/collection_grouping_test.cpp
+++ b/test/collection_grouping_test.cpp
@@ -303,4 +303,18 @@ TEST_F(CollectionGroupingTest, GroupingWithArrayFieldAndOverride) {
ASSERT_EQ(1, res["grouped_hits"][3]["hits"].size());
ASSERT_STREQ("8", res["grouped_hits"][3]["hits"][0]["document"]["id"].get<std::string>().c_str());
+
+ // assert facet counts
+ ASSERT_STREQ("brand", res["facet_counts"][0]["field_name"].get<std::string>().c_str());
+ ASSERT_EQ(2, (int) res["facet_counts"][0]["counts"][0]["count"]);
+ ASSERT_STREQ("Omega", res["facet_counts"][0]["counts"][0]["value"].get<std::string>().c_str());
+
+ ASSERT_EQ(2, (int) res["facet_counts"][0]["counts"][1]["count"]);
+ ASSERT_STREQ("Xorp", res["facet_counts"][0]["counts"][1]["value"].get<std::string>().c_str());
+
+ ASSERT_EQ(2, (int) res["facet_counts"][0]["counts"][2]["count"]);
+ ASSERT_STREQ("Beta", res["facet_counts"][0]["counts"][2]["value"].get<std::string>().c_str());
+
+ ASSERT_EQ(1, (int) res["facet_counts"][0]["counts"][3]["count"]);
+ ASSERT_STREQ("Zeta", res["facet_counts"][0]["counts"][3]["value"].get<std::string>().c_str());
}
\ No newline at end of file
diff --git a/test/collection_sorting_test.cpp b/test/collection_sorting_test.cpp
index bd983a05..e552f307 100644
--- a/test/collection_sorting_test.cpp
+++ b/test/collection_sorting_test.cpp
@@ -249,6 +249,7 @@ TEST_F(CollectionSortingTest, ThreeSortFieldsLimit) {
sort_by("min", "DESC"),
};
+ query_fields = {"title"};
auto res_op = coll1->search("the", query_fields, "", {}, sort_fields_desc, 0, 10, 1, FREQUENCY, false);
ASSERT_FALSE(res_op.ok());
diff --git a/test/collection_test.cpp b/test/collection_test.cpp
index ec5c3649..12748830 100644
--- a/test/collection_test.cpp
+++ b/test/collection_test.cpp
@@ -458,10 +458,16 @@ TEST_F(CollectionTest, WildcardQuery) {
}
// wildcard query should not require a search field
- results_op = collection->search("*", {}, "", {}, sort_fields, 0, 3, 1, FREQUENCY, false).get();
+ results_op = collection->search("*", {}, "", {}, sort_fields, 0, 3, 1, FREQUENCY, false);
ASSERT_TRUE(results_op.ok());
+ results = results_op.get();
ASSERT_EQ(3, results["hits"].size());
ASSERT_EQ(25, results["found"].get<uint32_t>());
+
+ // non-wildcard query should require a search field
+ results_op = collection->search("the", {}, "", {}, sort_fields, 0, 3, 1, FREQUENCY, false);
+ ASSERT_FALSE(results_op.ok());
+ ASSERT_STREQ("No search fields specified for the query.", results_op.error().c_str());
}
TEST_F(CollectionTest, PrefixSearching) {