Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences
C++ algoliadatastoreelasticsearchenterprise-searchfacetingfull-text-searchfuzzy-searchgeosearchin-memoryinstantsearchmerchandisingpineconesearchsearch-enginesemantic-searchsimilarity-searchsite-searchsynonymstypo-tolerancevector-search
Bug fix: exact filtering with a typo in a token.
Kishore Nallana0f6bd43478f
diff --git a/src/index.cpp b/src/index.cppindex c3d423cc..b56aee96 100644--- a/src/index.cpp+++ b/src/index.cpp@@ -1010,7 +1010,7 @@ Option<uint32_t> Index::do_filtering(uint32_t** filter_ids_out, const std::vectobool found_filter = false;if(!f.is_array()) {- found_filter = (str_tokens.size() == fvalues.size());+ found_filter = (query_suggestion.size() == fvalues.size());} else {uint64_t filter_hash = 1;diff --git a/test/collection_faceting_test.cpp b/test/collection_faceting_test.cppindex 7748cbf4..f1a9dd88 100644--- a/test/collection_faceting_test.cpp+++ b/test/collection_faceting_test.cpp@@ -71,6 +71,11 @@ TEST_F(CollectionFacetingTest, FacetFieldStringFiltering) {ASSERT_EQ(0, results["hits"].size());ASSERT_EQ(0, results["found"].get<size_t>());+ // multiple tokens but with a typo on one of them+ results = coll_str->search("*", query_fields, "starring:= ssamuel l. Jackson", facets, sort_fields, 0, 10, 1, FREQUENCY, false).get();+ ASSERT_EQ(0, results["hits"].size());+ ASSERT_EQ(0, results["found"].get<size_t>());+// same should succeed when verbatim filter is maderesults = coll_str->search("*", query_fields, "starring:= samuel l. Jackson", facets, sort_fields, 0, 10, 1, FREQUENCY, false).get();ASSERT_EQ(2, results["hits"].size());@@ -85,6 +90,11 @@ TEST_F(CollectionFacetingTest, FacetFieldStringFiltering) {ASSERT_EQ(2, results["hits"].size());ASSERT_EQ(2, results["found"].get<size_t>());+ // contains when only 1 token matches+ results = coll_str->search("*", query_fields, "starring: samuel johnson", facets, sort_fields, 0, 10, 1, FREQUENCY, false).get();+ ASSERT_EQ(2, results["hits"].size());+ ASSERT_EQ(2, results["found"].get<size_t>());+collectionManager.drop_collection("coll_str");}@@ -131,6 +141,9 @@ TEST_F(CollectionFacetingTest, FacetFieldStringArrayFiltering) {results = coll_array_fields->search("Jeremy", query_fields, "tags:= FINE", facets, sort_fields, 0, 10, 1, FREQUENCY, false).get();ASSERT_EQ(0, results["hits"].size());+ results = coll_array_fields->search("Jeremy", query_fields, "tags:= FFINE PLATINUM", facets, sort_fields, 0, 10, 1, FREQUENCY, false).get();+ ASSERT_EQ(0, results["hits"].size());+// partial token filter should be made without "=" operatorresults = coll_array_fields->search("Jeremy", query_fields, "tags: PLATINUM", facets, sort_fields, 0, 10, 1, FREQUENCY, false).get();ASSERT_EQ(1, results["hits"].size());