Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Add `reference_fields` map in `Collection`.

Harpreet Sangara11a899a4c8e
diff --git a/include/index.h b/include/index.h
index 600d3c6f..8742300f 100644
--- a/include/index.h
+++ b/include/index.h
@@ -704,7 +704,7 @@ public:
void do_reference_filtering_with_lock(std::pair<uint32_t, uint32_t*>& reference_index_ids,
filter_node_t* filter_tree_root,
- const std::string& reference_field_name) const;
+ const std::string& reference_helper_field_name) const;
void refresh_schemas(const std::vector<field>& new_fields, const std::vector<field>& del_fields);
diff --git a/src/index.cpp b/src/index.cpp
index 135d073c..f9ba9f35 100644
--- a/src/index.cpp
+++ b/src/index.cpp
@@ -2113,13 +2113,6 @@ void copy_reference_ids(filter_result_t& from, filter_result_t& to) {
}
}
}
-
- do_filtering(root);
- filter_ids_length = root->match_index_ids.first;
- filter_ids = root->match_index_ids.second;
-
- // Prevents double deletion. We'll be deleting this array upstream and when the filter tree is destructed.
- root->match_index_ids.second = nullptr;
}
Option<bool> Index::recursive_filter(filter_node_t* const root,
diff --git a/test/collection_join_test.cpp b/test/collection_join_test.cpp
index 9db121aa..b25439e6 100644
--- a/test/collection_join_test.cpp
+++ b/test/collection_join_test.cpp
@@ -265,6 +265,7 @@ TEST_F(CollectionJoinTest, IndexDocumentHavingReferenceField) {
}
ASSERT_TRUE(add_op.ok());
}
+
collectionManager.drop_collection("Customers");
customers_schema_json =
R"({
@@ -708,4 +709,4 @@ TEST_F(CollectionJoinTest, IncludeFieldsByReference_SingleMatch) {
// // 3 fields in Products document and 2 fields from Customers document
// ASSERT_EQ(5, res_obj["hits"][0]["document"].size());
// ASSERT_EQ(1, res_obj["hits"][0]["document"].count("product_id_sequence_id"));
-}
\ No newline at end of file
+}