Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix synonym deletion regression.

Kishore Nallana1b7f9c8e2f9
diff --git a/src/synonym_index.cpp b/src/synonym_index.cpp
index d41ddf00..df6d9329 100644
--- a/src/synonym_index.cpp
+++ b/src/synonym_index.cpp
@@ -183,7 +183,10 @@ Option<bool> SynonymIndex::remove_synonym(const std::string & collection_name, c
const auto& synonym = synonym_definitions.at(syn_iter->second);
std::vector<std::string> keys;
keys.insert(keys.end(), synonym.root.begin(), synonym.root.end());
- keys.insert(keys.end(), synonym.raw_synonyms.begin(), synonym.raw_synonyms.end());
+ for(const auto & syn_tokens : synonym.synonyms) {
+ auto synonyms_str = StringUtils::join(syn_tokens, " ");
+ keys.push_back(synonyms_str);
+ }
for(const auto& key : keys) {
art_leaf* found_leaf = (art_leaf *) art_search(synonym_index_tree, (unsigned char *) key.c_str(), key.size() + 1);
diff --git a/test/collection_synonyms_test.cpp b/test/collection_synonyms_test.cpp
index bca96311..6d8ec481 100644
--- a/test/collection_synonyms_test.cpp
+++ b/test/collection_synonyms_test.cpp
@@ -697,11 +697,19 @@ TEST_F(CollectionSynonymsTest, SynonymFieldOrdering) {
}
TEST_F(CollectionSynonymsTest, DeleteAndUpsertDuplicationOfSynonms) {
- coll_mul_fields->add_synonym(R"({"id": "ipod-synonyms", "root": "ipod", "synonyms": ["i pod", "ipod"]})"_json);
+ coll_mul_fields->add_synonym(R"({"id": "ipod-synonyms", "synonyms": ["i pod", "Apple Phone"]})"_json);
+ coll_mul_fields->add_synonym(R"({"id": "case-synonyms", "root": "Cases", "synonyms": ["phone cover", "mobile protector"]})"_json);
coll_mul_fields->add_synonym(R"({"id": "samsung-synonyms", "root": "s3", "synonyms": ["s3 phone", "samsung"]})"_json);
- ASSERT_EQ(2, coll_mul_fields->get_synonyms().get().size());
+ ASSERT_EQ(3, coll_mul_fields->get_synonyms().get().size());
coll_mul_fields->remove_synonym("ipod-synonyms");
+ coll_mul_fields->remove_synonym("case-synonyms");
+
+ auto res_op = coll_mul_fields->search("apple phone", {"starring"}, "", {}, {}, {0}, 10, 1, FREQUENCY, {true});
+ ASSERT_TRUE(res_op.ok());
+
+ res_op = coll_mul_fields->search("cases", {"starring"}, "", {}, {}, {0}, 10, 1, FREQUENCY, {true});
+ ASSERT_TRUE(res_op.ok());
auto synonyms = coll_mul_fields->get_synonyms().get();
ASSERT_EQ(1, synonyms.size());