Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Enable ART to index and search on floating point numbers.

Kishore Nallana2f475d7fce1
diff --git a/include/art.h b/include/art.h
index 878378cd..f807cf44 100644
--- a/include/art.h
+++ b/include/art.h
@@ -255,10 +255,14 @@ void encode_int32(int32_t n, unsigned char *chars);
void encode_int64(int64_t n, unsigned char *chars);
+void encode_float(float n, unsigned char *chars);
+
int art_int32_search(art_tree *t, int32_t value, NUM_COMPARATOR comparator, std::vector<const art_leaf *> &results);
int art_int64_search(art_tree *t, int64_t value, NUM_COMPARATOR comparator, std::vector<const art_leaf *> &results);
+int art_float_search(art_tree *t, float value, NUM_COMPARATOR comparator, std::vector<const art_leaf *> &results);
+
#ifdef __cplusplus
}
#endif
diff --git a/src/art.cpp b/src/art.cpp
index aae8e286..3ac2d47f 100644
--- a/src/art.cpp
+++ b/src/art.cpp
@@ -11,6 +11,7 @@
#include <iostream>
#include <limits>
#include <queue>
+#include <stdint.h>
#include "art.h"
/**
@@ -1395,6 +1396,14 @@ void encode_int64(int64_t n, unsigned char *chars) {
}
}
+// See: https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/util/OrderedBytes.java#L1372
+void encode_float(float n, unsigned char *chars) {
+ int32_t i;
+ memcpy(&i, &n, sizeof(int32_t));
+ i ^= ((i >> (std::numeric_limits<int32_t>::digits - 1)) | INT32_MIN);
+ encode_int32(i, chars);
+}
+
// Implements ==, <= and >=
recurse_progress matches(unsigned char a, unsigned char b, NUM_COMPARATOR comparator) {
switch(comparator) {
@@ -1604,4 +1613,11 @@ int art_int64_search(art_tree *t, int64_t value, NUM_COMPARATOR comparator, std:
encode_int64(value, chars);
art_int_fuzzy_recurse(t->root, 0, chars, 8, comparator, results);
return 0;
+}
+
+int art_float_search(art_tree *t, float value, NUM_COMPARATOR comparator, std::vector<const art_leaf *> &results) {
+ unsigned char chars[8];
+ encode_float(value, chars);
+ art_int_fuzzy_recurse(t->root, 0, chars, 8, comparator, results);
+ return 0;
}
\ No newline at end of file
diff --git a/test/art_test.cpp b/test/art_test.cpp
index ecdbdcd7..0932f37a 100644
--- a/test/art_test.cpp
+++ b/test/art_test.cpp
@@ -1115,4 +1115,93 @@ TEST(ArtTest, test_int32_array) {
int res = art_int32_search(&t, 2002, GREATER_THAN, results);
ASSERT_TRUE(res == 0);
ASSERT_EQ(3, results.size());
+}
+
+TEST(ArtTest, test_encode_float_positive) {
+ art_tree t;
+ art_tree_init(&t);
+
+ float floats[6] = {0.0, 0.1044, 1.004, 1.99, 10.5678, 100.33};
+ const int CHAR_LEN = 8;
+
+ for(size_t i = 0; i < 6; i++) {
+ unsigned char chars0[CHAR_LEN];
+ encode_float(floats[i], chars0);
+ art_document doc = get_document(i);
+ ASSERT_TRUE(NULL == art_insert(&t, (unsigned char*)chars0, CHAR_LEN, &doc, 1));
+ }
+
+ std::vector<const art_leaf*> results;
+
+ int res = art_float_search(&t, 0.0, EQUALS, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(1, results.size());
+ results.clear();
+
+ res = art_float_search(&t, 10.5678, LESS_THAN, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(4, results.size());
+ results.clear();
+
+ res = art_float_search(&t, 10.5678, LESS_THAN_EQUALS, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(5, results.size());
+ results.clear();
+
+ res = art_float_search(&t, 10.5678, GREATER_THAN, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(1, results.size());
+ results.clear();
+
+ res = art_float_search(&t, 10.5678, GREATER_THAN_EQUALS, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(2, results.size());
+ results.clear();
+}
+
+TEST(ArtTest, test_encode_float_positive_negative) {
+ art_tree t;
+ art_tree_init(&t);
+
+ float floats[6] = {-24.1033, -2.561, 0.0, 1.99, 10.5678, 100.33};
+ const int CHAR_LEN = 8;
+
+ for(size_t i = 0; i < 6; i++) {
+ unsigned char chars0[CHAR_LEN];
+ encode_float(floats[i], chars0);
+ art_document doc = get_document(i);
+ ASSERT_TRUE(NULL == art_insert(&t, (unsigned char*)chars0, CHAR_LEN, &doc, 1));
+ }
+
+ std::vector<const art_leaf*> results;
+
+ int res = art_float_search(&t, -24.1033, EQUALS, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(1, results.size());
+ results.clear();
+
+ res = art_float_search(&t, 0.0, LESS_THAN, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(2, results.size());
+ results.clear();
+
+ res = art_float_search(&t, 0.0, GREATER_THAN, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(3, results.size());
+ results.clear();
+
+ res = art_float_search(&t, -2.561, LESS_THAN_EQUALS, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(2, results.size());
+ results.clear();
+
+ res = art_float_search(&t, -2.561, GREATER_THAN, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(4, results.size());
+ results.clear();
+
+ res = art_float_search(&t, -24.1033, GREATER_THAN_EQUALS, results);
+ ASSERT_TRUE(res == 0);
+ ASSERT_EQ(6, results.size());
+ results.clear();
}
\ No newline at end of file