Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences
C++ algoliadatastoreelasticsearchenterprise-searchfacetingfull-text-searchfuzzy-searchgeosearchin-memoryinstantsearchmerchandisingpineconesearchsearch-enginesemantic-searchsimilarity-searchsite-searchsynonymstypo-tolerancevector-search
Update `parse_vector_query_str`
ozanarmagana44f996a1b8e
diff --git a/include/vector_query_ops.h b/include/vector_query_ops.hindex 3fc033d1..ac124ca8 100644--- a/include/vector_query_ops.h+++ b/include/vector_query_ops.h@@ -33,5 +33,5 @@ public:static Option<bool> parse_vector_query_str(const std::string& vector_query_str, vector_query_t& vector_query,const bool is_wildcard_query,const Collection* coll,- const bool allow_empty_query = false);+ const bool allow_empty_query);};\ No newline at end of filediff --git a/src/collection.cpp b/src/collection.cppindex 84ec2184..1bc16495 100644--- a/src/collection.cpp+++ b/src/collection.cpp@@ -1250,7 +1250,7 @@ Option<nlohmann::json> Collection::search(std::string raw_query,bool is_wildcard_query = (raw_query == "*" || raw_query.empty());auto parse_vector_op = VectorQueryOps::parse_vector_query_str(vector_query_str, vector_query,- is_wildcard_query, this);+ is_wildcard_query, this, false);if(!parse_vector_op.ok()) {return Option<nlohmann::json>(400, parse_vector_op.error());}diff --git a/test/vector_query_ops_test.cpp b/test/vector_query_ops_test.cppindex e2c81e71..d1846ea6 100644--- a/test/vector_query_ops_test.cpp+++ b/test/vector_query_ops_test.cpp@@ -17,7 +17,7 @@ protected:TEST_F(VectorQueryOpsTest, ParseVectorQueryString) {vector_query_t vector_query;- auto parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], k: 10)", vector_query, false, nullptr);+ auto parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], k: 10)", vector_query, false, nullptr, false);ASSERT_TRUE(parsed.ok());ASSERT_EQ("vec", vector_query.field_name);ASSERT_EQ(10, vector_query.k);@@ -28,49 +28,49 @@ TEST_F(VectorQueryOpsTest, ParseVectorQueryString) {}vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], k: 10)", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], k: 10)", vector_query, false, nullptr, false);ASSERT_TRUE(parsed.ok());vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:([])", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:([])", vector_query, false, nullptr, false);ASSERT_FALSE(parsed.ok());ASSERT_EQ("When a vector query value is empty, an `id` parameter must be present.", parsed.error());// cannot pass both vector and idvector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], id: 10)", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], id: 10)", vector_query, false, nullptr, false);ASSERT_FALSE(parsed.ok());ASSERT_EQ("Malformed vector query string: cannot pass both vector query and `id` parameter.", parsed.error());vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:([], k: 10)", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:([], k: 10)", vector_query, false, nullptr, false);ASSERT_TRUE(parsed.ok());vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:([], k: 10)", vector_query, true, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:([], k: 10)", vector_query, true, nullptr, false);ASSERT_TRUE(parsed.ok());vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:[0.34, 0.66, 0.12, 0.68], k: 10)", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:[0.34, 0.66, 0.12, 0.68], k: 10)", vector_query, false, nullptr, false);ASSERT_FALSE(parsed.ok());ASSERT_EQ("Malformed vector query string.", parsed.error());vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], k: 10", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], k: 10", vector_query, false, nullptr, false);ASSERT_TRUE(parsed.ok());vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:(0.34, 0.66, 0.12, 0.68, k: 10)", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:(0.34, 0.66, 0.12, 0.68, k: 10)", vector_query, false, nullptr, false);ASSERT_FALSE(parsed.ok());ASSERT_EQ("Malformed vector query string.", parsed.error());vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], )", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], )", vector_query, false, nullptr, false);ASSERT_FALSE(parsed.ok());ASSERT_EQ("Malformed vector query string.", parsed.error());vector_query._reset();- parsed = VectorQueryOps::parse_vector_query_str("vec([0.34, 0.66, 0.12, 0.68])", vector_query, false, nullptr);+ parsed = VectorQueryOps::parse_vector_query_str("vec([0.34, 0.66, 0.12, 0.68])", vector_query, false, nullptr, false);ASSERT_FALSE(parsed.ok());ASSERT_EQ("Malformed vector query string.", parsed.error());}