Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Address change in streaming behavior of h2o on http/2.

Kishore Nallana99929f05fa0
diff --git a/src/http_server.cpp b/src/http_server.cpp
index 9fbfb2a5..50391ed8 100644
--- a/src/http_server.cpp
+++ b/src/http_server.cpp
@@ -569,13 +569,11 @@ int HttpServer::async_req_cb(void *ctx, int is_end_stream) {
bool async_req = custom_generator->rpath->async_req;
bool is_http_v1 = (0x101 <= request->_req->version && request->_req->version < 0x200);
- /*
- LOG(INFO) << "async_req_cb, chunk.len=" << chunk.len
+ /*LOG(INFO) << "async_req_cb, chunk.len=" << chunk.len
<< ", is_http_v1: " << is_http_v1
- << ", request->req->entity.len=" << request->req->entity.len
- << ", content_len: " << request->req->content_length
- << ", is_end_stream=" << is_end_stream;
- */
+ << ", request->req->entity.len=" << request->_req->entity.len
+ << ", content_len: " << request->_req->content_length
+ << ", is_end_stream=" << is_end_stream;*/
// disallow specific curl clients from using import call via http2
// detects: https://github.com/curl/curl/issues/1410
diff --git a/src/raft_server.cpp b/src/raft_server.cpp
index 48584937..f33a6518 100644
--- a/src/raft_server.cpp
+++ b/src/raft_server.cpp
@@ -254,7 +254,7 @@ void ReplicationState::write_to_leader(const std::shared_ptr<http_req>& request,
// Handle no leader scenario
LOG(ERROR) << "Rejecting write: could not find a leader.";
- if(request->_req->proceed_req && response->proxied_stream) {
+ if(response->proxied_stream) {
// streaming in progress: ensure graceful termination (cannot start response again)
LOG(ERROR) << "Terminating streaming request gracefully.";
response->is_alive = false;
@@ -267,7 +267,7 @@ void ReplicationState::write_to_leader(const std::shared_ptr<http_req>& request,
return message_dispatcher->send_message(HttpServer::STREAM_RESPONSE_MESSAGE, req_res);
}
- if (request->_req->proceed_req && response->proxied_stream) {
+ if (response->proxied_stream) {
// indicates async request body of in-flight request
//LOG(INFO) << "Inflight proxied request, returning control to caller, body_size=" << request->body.size();
request->notify();