Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

fix: duplicate fields (#328)

Harisaran Gb7b0fe84c275
diff --git a/include/field.h b/include/field.h
index 0ad27629..420d7fc7 100644
--- a/include/field.h
+++ b/include/field.h
@@ -199,6 +199,9 @@ struct field {
nlohmann::json& fields_json) {
bool found_default_sorting_field = false;
+ // Check for duplicates in field names
+ std::set<std::string> field_names;
+
for(const field & field: fields) {
if(field.name == "id") {
continue;
@@ -252,6 +255,7 @@ struct field {
return Option<bool>(400, "Field `" + field.name + "` cannot be a facet since "
"it's marked as non-indexable.");
}
+ field_names.insert(field.name);
}
if(!default_sorting_field.empty() && !found_default_sorting_field) {
@@ -259,6 +263,10 @@ struct field {
"` but is not found in the schema.");
}
+ if (field_names.size() != fields.size()) {
+ return Option<bool>(400, "Duplicate field names should not be present in `fields`");
+ }
+
return Option<bool>(true);
}