Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences
C++ algoliadatastoreelasticsearchenterprise-searchfacetingfull-text-searchfuzzy-searchgeosearchin-memoryinstantsearchmerchandisingpineconesearchsearch-enginesemantic-searchsimilarity-searchsite-searchsynonymstypo-tolerancevector-search
Use equal spaced sampling instead of rand.
Kishore Nallanbc37cf3209fb
diff --git a/src/index.cpp b/src/index.cppindex f85b55d3..01d14ed3 100644--- a/src/index.cpp+++ b/src/index.cpp@@ -1248,22 +1248,17 @@ void Index::do_facets(std::vector<facet> & facets, facet_query_t & facet_query,}const auto& field_facet_mapping = field_facet_mapping_it->second;-- // used for sampling facets (if enabled)- std::mt19937 gen(137723); // use constant seed to make sure that counts don't jump around- std::uniform_int_distribution<> distr(1, 100); // 1 to 100 inclusive+ size_t mod_value = 100 / facet_sample_percent;for(size_t i = 0; i < results_size; i++) {- uint32_t doc_seq_id = result_ids[i];-// if sampling is enabled, we will skip a portion of the results to speed up thingsif(estimate_facets) {- size_t num = distr(gen);- if(num > facet_sample_percent) {+ if(i % mod_value != 0) {continue;}}+ uint32_t doc_seq_id = result_ids[i];const auto& facet_hashes_it = field_facet_mapping[doc_seq_id % ARRAY_FACET_DIM]->find(doc_seq_id);if(facet_hashes_it == field_facet_mapping[doc_seq_id % ARRAY_FACET_DIM]->end()) {diff --git a/test/collection_faceting_test.cpp b/test/collection_faceting_test.cppindex 8b0f9717..6bc3ef04 100644--- a/test/collection_faceting_test.cpp+++ b/test/collection_faceting_test.cpp@@ -1288,9 +1288,12 @@ TEST_F(CollectionFacetingTest, SampleFacetCounts) {Collection* coll1 = collectionManager.create_collection(schema).get();+ std::mt19937 gen(137723); // use constant seed to make sure that counts don't jump around+ std::uniform_int_distribution<> distr(1, 100); // 1 to 100 inclusive+for(size_t i = 0; i < 1000; i++) {nlohmann::json doc;- if(i % 2 == 0) {+ if(distr(gen) % 2 == 0) {doc["color"] = "blue";} else {doc["color"] = "red";@@ -1325,9 +1328,8 @@ TEST_F(CollectionFacetingTest, SampleFacetCounts) {ASSERT_EQ(1, res["facet_counts"].size());ASSERT_EQ(2, res["facet_counts"][0]["counts"].size());- // verify approximate counts- ASSERT_EQ(500, res["facet_counts"][0]["counts"][0]["count"].get<size_t>());- ASSERT_EQ(500, res["facet_counts"][0]["counts"][1]["count"].get<size_t>());+ ASSERT_EQ(512, res["facet_counts"][0]["counts"][0]["count"].get<size_t>());+ ASSERT_EQ(488, res["facet_counts"][0]["counts"][1]["count"].get<size_t>());ASSERT_FALSE(res["facet_counts"][0]["sampled"].get<bool>());// test for sample percent > 100