Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences
C++ algoliadatastoreelasticsearchenterprise-searchfacetingfull-text-searchfuzzy-searchgeosearchin-memoryinstantsearchmerchandisingpineconesearchsearch-enginesemantic-searchsimilarity-searchsite-searchsynonymstypo-tolerancevector-search
Fix bug with deeply nested optional array of obj field.
Kishore Nallanc71245ca1410
diff --git a/src/field.cpp b/src/field.cppindex ea99b72f..8c613e0c 100644--- a/src/field.cpp+++ b/src/field.cpp@@ -1022,9 +1022,11 @@ Option<bool> field::flatten_field(nlohmann::json& doc, nlohmann::json& obj, consreturn flatten_field(doc, it.value(), the_field, path_parts, path_index + 1, has_array, has_obj_array,is_update, dyn_fields, flattened_fields);}- } {+ } else if(!the_field.optional) {return Option<bool>(404, "Field `" + the_field.name + "` not found.");}++ return Option<bool>(true);}Option<bool> field::flatten_doc(nlohmann::json& document,diff --git a/test/collection_nested_fields_test.cpp b/test/collection_nested_fields_test.cppindex 1c4bfb24..bcab0f73 100644--- a/test/collection_nested_fields_test.cpp+++ b/test/collection_nested_fields_test.cpp@@ -3056,6 +3056,81 @@ TEST_F(CollectionNestedFieldsTest, HighlightArrayOfObjects) {ASSERT_EQ(1, results["hits"][0]["highlight"]["details"][2].size());}+TEST_F(CollectionNestedFieldsTest, DeepNestedOptionalArrayValue) {+ nlohmann::json schema = R"({+ "name": "coll1",+ "enable_nested_fields": true,+ "fields": [+ {+ "facet": false,+ "index": true,+ "infix": false,+ "locale": "",+ "name": "items.name",+ "optional": true,+ "sort": false,+ "type": "string[]"+ },+ {+ "facet": false,+ "index": true,+ "infix": false,+ "locale": "",+ "name": "items.description",+ "optional": true,+ "sort": false,+ "type": "string[]"+ },+ {+ "facet": false,+ "index": true,+ "infix": false,+ "locale": "",+ "name": "items.nested_items.name",+ "optional": true,+ "sort": false,+ "type": "string[]"+ }+ ]+ })"_json;++ auto op = collectionManager.create_collection(schema);+ ASSERT_TRUE(op.ok());+ Collection* coll1 = op.get();++ auto doc1 = R"({+ "items": [+ {+ "description": "random description.",+ "name": "foobar",+ "nested_items": [+ {+ "isAvailable": true+ },+ {+ "description": "nested description here",+ "isAvailable": true,+ "name": "naruto"+ },+ {+ "description": "description again",+ "isAvailable": true,+ "name": "dragon ball"+ }+ ]+ }+ ]+ })"_json;++ auto add_op = coll1->add(doc1.dump(), CREATE);+ ASSERT_TRUE(add_op.ok());++ auto results = coll1->search("naruto", {"items.nested_items.name"}, "", {}, {}, {0}, 10, 1, FREQUENCY,+ {true}, 1, spp::sparse_hash_set<std::string>(),+ spp::sparse_hash_set<std::string>(), 10, "", 30, 4).get();+ ASSERT_EQ(1, results["found"].get<size_t>());+}+TEST_F(CollectionNestedFieldsTest, FloatInsideNestedObject) {nlohmann::json schema = R"({"name": "coll1",