Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Use k value from vector query params.

Kishore Nallanc8afd1e7c67d
diff --git a/include/field.h b/include/field.h
index 0ff3d7d4..b0db0a22 100644
--- a/include/field.h
+++ b/include/field.h
@@ -571,14 +571,12 @@ struct sort_by {
struct vector_query_t {
std::string field_name;
size_t k = 0;
- bool exact = false;
std::vector<float> values;
void _reset() {
// used for testing only
field_name.clear();
k = 0;
- exact = false;
values.clear();
}
};
diff --git a/src/collection_manager.cpp b/src/collection_manager.cpp
index 711ee406..acc05db5 100644
--- a/src/collection_manager.cpp
+++ b/src/collection_manager.cpp
@@ -1454,14 +1454,6 @@ bool CollectionManager::parse_vector_query_str(std::string vector_query_str, vec
vector_query.k = std::stoul(param_kv[1]);
}
-
- if(param_kv[0] == "exact") {
- if(!StringUtils::is_bool(param_kv[1])) {
- return false;
- }
-
- vector_query.exact = (param_kv[1] == "true") ;
- }
}
return true;
diff --git a/src/index.cpp b/src/index.cpp
index c7acb92a..4c8adf74 100644
--- a/src/index.cpp
+++ b/src/index.cpp
@@ -2548,7 +2548,8 @@ void Index::search(std::vector<query_tokens_t>& field_query_tokens, const std::v
collate_included_ids({}, included_ids_map, curated_topster, searched_queries);
if(!vector_query.field_name.empty()) {
- auto k = per_page * page;
+ auto k = std::max<size_t>(vector_query.k, per_page * page);
+
VectorFilterFunctor filterFunctor(filter_ids, filter_ids_length);
auto& field_vector_index = vector_index.at(vector_query.field_name);
diff --git a/test/collection_manager_test.cpp b/test/collection_manager_test.cpp
index a7fe2f07..552b4098 100644
--- a/test/collection_manager_test.cpp
+++ b/test/collection_manager_test.cpp
@@ -920,7 +920,7 @@ TEST_F(CollectionManagerTest, ParseSortByClause) {
TEST_F(CollectionManagerTest, ParseVectorQueryString) {
vector_query_t vector_query;
- bool parsed = CollectionManager::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], exact: false, k: 10)", vector_query);
+ bool parsed = CollectionManager::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], k: 10)", vector_query);
ASSERT_TRUE(parsed);
ASSERT_EQ("vec", vector_query.field_name);
ASSERT_EQ(10, vector_query.k);
@@ -935,15 +935,15 @@ TEST_F(CollectionManagerTest, ParseVectorQueryString) {
ASSERT_TRUE(parsed);
vector_query._reset();
- parsed = CollectionManager::parse_vector_query_str("vec:[0.34, 0.66, 0.12, 0.68], exact: false, k: 10)", vector_query);
+ parsed = CollectionManager::parse_vector_query_str("vec:[0.34, 0.66, 0.12, 0.68], k: 10)", vector_query);
ASSERT_FALSE(parsed);
vector_query._reset();
- parsed = CollectionManager::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], exact: false, k: 10", vector_query);
+ parsed = CollectionManager::parse_vector_query_str("vec:([0.34, 0.66, 0.12, 0.68], k: 10", vector_query);
ASSERT_TRUE(parsed);
vector_query._reset();
- parsed = CollectionManager::parse_vector_query_str("vec:(0.34, 0.66, 0.12, 0.68, exact: false, k: 10)", vector_query);
+ parsed = CollectionManager::parse_vector_query_str("vec:(0.34, 0.66, 0.12, 0.68, k: 10)", vector_query);
ASSERT_FALSE(parsed);
vector_query._reset();