Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Don't rewrite to meta data to store when loading collection.

Kishore Nalland3c1b77cefbd
diff --git a/include/collection.h b/include/collection.h
index c2312659..28dac299 100644
--- a/include/collection.h
+++ b/include/collection.h
@@ -494,7 +494,7 @@ public:
// Override operations
- Option<uint32_t> add_override(const override_t & override);
+ Option<uint32_t> add_override(const override_t & override, bool write_to_store = true);
Option<uint32_t> remove_override(const std::string & id);
@@ -509,7 +509,7 @@ public:
bool get_synonym(const std::string& id, synonym_t& synonym);
- Option<bool> add_synonym(const nlohmann::json& syn_json);
+ Option<bool> add_synonym(const nlohmann::json& syn_json, bool write_to_store = true);
Option<bool> remove_synonym(const std::string & id);
diff --git a/include/synonym_index.h b/include/synonym_index.h
index a8b855ee..55d4dd24 100644
--- a/include/synonym_index.h
+++ b/include/synonym_index.h
@@ -73,7 +73,8 @@ public:
bool get_synonym(const std::string& id, synonym_t& synonym);
- Option<bool> add_synonym(const std::string & collection_name, const synonym_t& synonym);
+ Option<bool> add_synonym(const std::string & collection_name, const synonym_t& synonym,
+ bool write_to_store = true);
Option<bool> remove_synonym(const std::string & collection_name, const std::string & id);
};
\ No newline at end of file
diff --git a/src/collection.cpp b/src/collection.cpp
index d9fa4d90..47792ebe 100644
--- a/src/collection.cpp
+++ b/src/collection.cpp
@@ -3348,10 +3348,12 @@ Option<bool> Collection::remove_if_found(uint32_t seq_id, const bool remove_from
return Option<bool>(true);
}
-Option<uint32_t> Collection::add_override(const override_t & override) {
- bool inserted = store->insert(Collection::get_override_key(name, override.id), override.to_json().dump());
- if(!inserted) {
- return Option<uint32_t>(500, "Error while storing the override on disk.");
+Option<uint32_t> Collection::add_override(const override_t & override, bool write_to_store) {
+ if(write_to_store) {
+ bool inserted = store->insert(Collection::get_override_key(name, override.id), override.to_json().dump());
+ if(!inserted) {
+ return Option<uint32_t>(500, "Error while storing the override on disk.");
+ }
}
std::unique_lock lock(mutex);
@@ -3568,7 +3570,7 @@ Option<bool> Collection::parse_pinned_hits(const std::string& pinned_hits_str,
return Option<bool>(true);
}
-Option<bool> Collection::add_synonym(const nlohmann::json& syn_json) {
+Option<bool> Collection::add_synonym(const nlohmann::json& syn_json, bool write_to_store) {
std::shared_lock lock(mutex);
synonym_t synonym;
Option<bool> syn_op = synonym_t::parse(syn_json, synonym);
@@ -3577,7 +3579,7 @@ Option<bool> Collection::add_synonym(const nlohmann::json& syn_json) {
return syn_op;
}
- return synonym_index->add_synonym(name, synonym);
+ return synonym_index->add_synonym(name, synonym, write_to_store);
}
bool Collection::get_synonym(const std::string& id, synonym_t& synonym) {
diff --git a/src/collection_manager.cpp b/src/collection_manager.cpp
index 6c9398e3..140f0dc4 100644
--- a/src/collection_manager.cpp
+++ b/src/collection_manager.cpp
@@ -1281,7 +1281,7 @@ Option<bool> CollectionManager::load_collection(const nlohmann::json &collection
override_t override;
auto parse_op = override_t::parse(collection_override, "", override);
if(parse_op.ok()) {
- collection->add_override(override);
+ collection->add_override(override, false);
} else {
LOG(ERROR) << "Skipping loading of override: " << parse_op.error();
}
@@ -1295,7 +1295,7 @@ Option<bool> CollectionManager::load_collection(const nlohmann::json &collection
for(const auto & collection_synonym_json: collection_synonym_jsons) {
nlohmann::json collection_synonym = nlohmann::json::parse(collection_synonym_json);
- collection->add_synonym(collection_synonym);
+ collection->add_synonym(collection_synonym, false);
}
// restore query suggestions configs
diff --git a/src/synonym_index.cpp b/src/synonym_index.cpp
index 79505c4b..676d5816 100644
--- a/src/synonym_index.cpp
+++ b/src/synonym_index.cpp
@@ -105,7 +105,8 @@ void SynonymIndex::synonym_reduction(const std::vector<std::string>& tokens,
synonym_reduction_internal(tokens, tokens.size(), 0, processed_syn_hashes, results);
}
-Option<bool> SynonymIndex::add_synonym(const std::string & collection_name, const synonym_t& synonym) {
+Option<bool> SynonymIndex::add_synonym(const std::string & collection_name, const synonym_t& synonym,
+ bool write_to_store) {
if(synonym_definitions.count(synonym.id) != 0) {
// first we have to delete existing entries so we can upsert
Option<bool> rem_op = remove_synonym(collection_name, synonym.id);
@@ -129,9 +130,11 @@ Option<bool> SynonymIndex::add_synonym(const std::string & collection_name, cons
write_lock.unlock();
- bool inserted = store->insert(get_synonym_key(collection_name, synonym.id), synonym.to_view_json().dump());
- if(!inserted) {
- return Option<bool>(500, "Error while storing the synonym on disk.");
+ if(write_to_store) {
+ bool inserted = store->insert(get_synonym_key(collection_name, synonym.id), synonym.to_view_json().dump());
+ if(!inserted) {
+ return Option<bool>(500, "Error while storing the synonym on disk.");
+ }
}
return Option<bool>(true);