Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Address warnings.

Kishore Nalland75e834ac335
diff --git a/src/art.cpp b/src/art.cpp
index 0440d18f..c3261b70 100644
--- a/src/art.cpp
+++ b/src/art.cpp
@@ -642,8 +642,6 @@ static void* recursive_insert(art_node *n, art_node **ref, const unsigned char *
n->max_score = MAX(n->max_score, document->score);
}
- path.push_back(n);
-
// Check if given node has a prefix
if (n->partial_len) {
// Determine if the prefixes differ, since we need to split
diff --git a/test/core_api_utils_test.cpp b/test/core_api_utils_test.cpp
index 0492bb6a..989de802 100644
--- a/test/core_api_utils_test.cpp
+++ b/test/core_api_utils_test.cpp
@@ -72,6 +72,9 @@ TEST_F(CoreAPIUtilsTest, StatefulRemoveDocs) {
ASSERT_TRUE(done);
// match 12 documents (multiple batches)
+ for(auto& kv: deletion_state.index_ids) {
+ delete [] kv.second;
+ }
deletion_state.index_ids.clear();
deletion_state.offsets.clear();
deletion_state.num_removed = 0;
@@ -94,6 +97,9 @@ TEST_F(CoreAPIUtilsTest, StatefulRemoveDocs) {
ASSERT_TRUE(done);
// match 9 documents (multiple batches)
+ for(auto& kv: deletion_state.index_ids) {
+ delete [] kv.second;
+ }
deletion_state.index_ids.clear();
deletion_state.offsets.clear();
deletion_state.num_removed = 0;
@@ -122,6 +128,9 @@ TEST_F(CoreAPIUtilsTest, StatefulRemoveDocs) {
coll1->add(doc.dump());
}
+ for(auto& kv: deletion_state.index_ids) {
+ delete [] kv.second;
+ }
deletion_state.index_ids.clear();
deletion_state.offsets.clear();
deletion_state.num_removed = 0;
@@ -137,6 +146,9 @@ TEST_F(CoreAPIUtilsTest, StatefulRemoveDocs) {
// delete single doc
+ for(auto& kv: deletion_state.index_ids) {
+ delete [] kv.second;
+ }
deletion_state.index_ids.clear();
deletion_state.offsets.clear();
deletion_state.num_removed = 0;
@@ -150,6 +162,13 @@ TEST_F(CoreAPIUtilsTest, StatefulRemoveDocs) {
ASSERT_EQ(1, deletion_state.num_removed);
ASSERT_TRUE(done);
+ for(auto& kv: deletion_state.index_ids) {
+ delete [] kv.second;
+ }
+ deletion_state.index_ids.clear();
+ deletion_state.offsets.clear();
+ deletion_state.num_removed = 0;
+
// bad filter query
auto op = coll1->get_filter_ids("bad filter", deletion_state.index_ids);
ASSERT_FALSE(op.ok());