Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Add virtual destructors for polymorphic base classes

ozanarmagand8e51ce86a64
diff --git a/include/text_embedder_remote.h b/include/text_embedder_remote.h
index 7ddd20ac..652c0b61 100644
--- a/include/text_embedder_remote.h
+++ b/include/text_embedder_remote.h
@@ -33,6 +33,7 @@ class RemoteEmbedder {
static void init(ReplicationState* rs) {
raft_server = rs;
}
+ virtual ~RemoteEmbedder() = default;
};
diff --git a/include/text_embedder_tokenizer.h b/include/text_embedder_tokenizer.h
index a9b3a41b..e3fc737d 100644
--- a/include/text_embedder_tokenizer.h
+++ b/include/text_embedder_tokenizer.h
@@ -30,6 +30,7 @@ class TextEmbeddingTokenizer {
private:
public:
virtual encoded_input_t Encode(const std::string& text) = 0;
+ virtual ~TextEmbeddingTokenizer() = default;
};
class BertTokenizerWrapper : public TextEmbeddingTokenizer {