Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Refactor `std::unique_ptr<filter_node_t>` order.

Harpreet Sangarf3706f737baa
diff --git a/src/collection.cpp b/src/collection.cpp
index 9d1c0635..d35e2e10 100644
--- a/src/collection.cpp
+++ b/src/collection.cpp
@@ -2509,12 +2509,12 @@ Option<bool> Collection::get_filter_ids(const std::string& filter_query, filter_
filter_node_t* filter_tree_root = nullptr;
Option<bool> filter_op = filter::parse_filter_query(filter_query, search_schema,
store, doc_id_prefix, filter_tree_root);
+ std::unique_ptr<filter_node_t> filter_tree_root_guard(filter_tree_root);
+
if(!filter_op.ok()) {
return filter_op;
}
- std::unique_ptr<filter_node_t> filter_tree_root_guard(filter_tree_root);
-
return index->do_filtering_with_lock(filter_tree_root, filter_result, name);
}
@@ -2544,12 +2544,12 @@ Option<bool> Collection::get_approximate_reference_filter_ids(const std::string&
filter_node_t* filter_tree_root = nullptr;
Option<bool> parse_op = filter::parse_filter_query(filter_query, search_schema,
store, doc_id_prefix, filter_tree_root);
+ std::unique_ptr<filter_node_t> filter_tree_root_guard(filter_tree_root);
+
if(!parse_op.ok()) {
return parse_op;
}
- std::unique_ptr<filter_node_t> filter_tree_root_guard(filter_tree_root);
-
return index->get_approximate_reference_filter_ids_with_lock(filter_tree_root, filter_ids_length);
}
@@ -2567,12 +2567,12 @@ Option<bool> Collection::get_reference_filter_ids(const std::string & filter_que
filter_node_t* filter_tree_root = nullptr;
Option<bool> parse_op = filter::parse_filter_query(filter_query, search_schema,
store, doc_id_prefix, filter_tree_root);
+ std::unique_ptr<filter_node_t> filter_tree_root_guard(filter_tree_root);
+
if(!parse_op.ok()) {
return parse_op;
}
- std::unique_ptr<filter_node_t> filter_tree_root_guard(filter_tree_root);
-
// Reference helper field has the sequence id of other collection's documents.
auto field_name = reference_field_op.get() + REFERENCE_HELPER_FIELD_SUFFIX;
return index->do_reference_filtering_with_lock(filter_tree_root, filter_result, name, field_name);