Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Ensure that infix property is restored on restart.

Kishore Nallanf4993de8a1d3
diff --git a/include/field.h b/include/field.h
index f6753af8..75a4797e 100644
--- a/include/field.h
+++ b/include/field.h
@@ -241,6 +241,7 @@ struct field {
field_val[fields::facet] = field.facet;
field_val[fields::optional] = field.optional;
field_val[fields::sort] = field.sort;
+ field_val[fields::infix] = field.infix;
field_val[fields::locale] = field.locale;
diff --git a/src/collection_manager.cpp b/src/collection_manager.cpp
index 0bc6695b..691e2bd9 100644
--- a/src/collection_manager.cpp
+++ b/src/collection_manager.cpp
@@ -38,9 +38,13 @@ Collection* CollectionManager::init_collection(const nlohmann::json & collection
field_obj[fields::locale] = "";
}
+ if(field_obj.count(fields::infix) == 0) {
+ field_obj[fields::infix] = -1;
+ }
+
field f(field_obj[fields::name], field_obj[fields::type], field_obj[fields::facet],
field_obj[fields::optional], field_obj[fields::index], field_obj[fields::locale],
- true);
+ -1, field_obj[fields::infix]);
// value of `sort` depends on field type
if(field_obj.count(fields::sort) == 0) {
diff --git a/test/collection_manager_test.cpp b/test/collection_manager_test.cpp
index 1ad89b21..7872fbb2 100644
--- a/test/collection_manager_test.cpp
+++ b/test/collection_manager_test.cpp
@@ -26,7 +26,7 @@ protected:
search_fields = {
field("title", field_types::STRING, false, false, true, "en", false),
- field("starring", field_types::STRING, false, false, true, "", false),
+ field("starring", field_types::STRING, false, false, true, "", false, true),
field("cast", field_types::STRING_ARRAY, true, true, true, "", false),
field(".*_year", field_types::INT32, true, true),
field("location", field_types::GEOPOINT, false, true, true),
@@ -90,12 +90,12 @@ TEST_F(CollectionManagerTest, CollectionCreation) {
// we already call `collection1->get_next_seq_id` above, which is side-effecting
ASSERT_EQ(1, StringUtils::deserialize_uint32_t(next_seq_id));
ASSERT_EQ("{\"created_at\":12345,\"default_sorting_field\":\"points\",\"fallback_field_type\":\"\","
- "\"fields\":[{\"facet\":false,\"locale\":\"en\",\"name\":\"title\",\"optional\":false,\"sort\":false,\"type\":\"string\"},"
- "{\"facet\":false,\"locale\":\"\",\"name\":\"starring\",\"optional\":false,\"sort\":false,\"type\":\"string\"},"
- "{\"facet\":true,\"locale\":\"\",\"name\":\"cast\",\"optional\":true,\"sort\":false,\"type\":\"string[]\"},"
- "{\"facet\":true,\"locale\":\"\",\"name\":\".*_year\",\"optional\":true,\"sort\":true,\"type\":\"int32\"},"
- "{\"facet\":false,\"locale\":\"\",\"name\":\"location\",\"optional\":true,\"sort\":true,\"type\":\"geopoint\"},"
- "{\"facet\":false,\"locale\":\"\",\"name\":\"points\",\"optional\":false,\"sort\":true,\"type\":\"int32\"}],\"id\":0,"
+ "\"fields\":[{\"facet\":false,\"infix\":false,\"locale\":\"en\",\"name\":\"title\",\"optional\":false,\"sort\":false,\"type\":\"string\"},"
+ "{\"facet\":false,\"infix\":true,\"locale\":\"\",\"name\":\"starring\",\"optional\":false,\"sort\":false,\"type\":\"string\"},"
+ "{\"facet\":true,\"infix\":false,\"locale\":\"\",\"name\":\"cast\",\"optional\":true,\"sort\":false,\"type\":\"string[]\"},"
+ "{\"facet\":true,\"infix\":false,\"locale\":\"\",\"name\":\".*_year\",\"optional\":true,\"sort\":true,\"type\":\"int32\"},"
+ "{\"facet\":false,\"infix\":false,\"locale\":\"\",\"name\":\"location\",\"optional\":true,\"sort\":true,\"type\":\"geopoint\"},"
+ "{\"facet\":false,\"infix\":false,\"locale\":\"\",\"name\":\"points\",\"optional\":false,\"sort\":true,\"type\":\"int32\"}],\"id\":0,"
"\"name\":\"collection1\",\"num_memory_shards\":4,\"symbols_to_index\":[\"+\"],\"token_separators\":[\"-\"]}",
collection_meta_json);
ASSERT_EQ("1", next_collection_id);
@@ -113,13 +113,17 @@ TEST_F(CollectionManagerTest, ShouldInitCollection) {
ASSERT_EQ("foo", collection->get_default_sorting_field());
ASSERT_EQ(0, collection->get_created_at());
+ ASSERT_FALSE(collection->get_fields().at(0).infix);
+ ASSERT_FALSE(collection->get_fields().at(0).sort);
+ ASSERT_EQ("", collection->get_fields().at(0).locale);
+
delete collection;
// with non-default values
nlohmann::json collection_meta2 =
nlohmann::json::parse("{\"name\": \"foobar\", \"id\": 100, \"fields\": [{\"name\": \"org\", \"type\": "
- "\"string\", \"facet\": false}], \"created_at\": 12345,"
+ "\"string\", \"facet\": false, \"infix\": true, \"sort\": true, \"locale\": \"en\"}], \"created_at\": 12345,"
"\"default_sorting_field\": \"foo\","
"\"symbols_to_index\": [\"+\"], \"token_separators\": [\"-\"]}");
@@ -136,6 +140,10 @@ TEST_F(CollectionManagerTest, ShouldInitCollection) {
ASSERT_EQ(1, collection->get_symbols_to_index().size());
ASSERT_EQ('+', collection->get_symbols_to_index()[0]);
+ ASSERT_TRUE(collection->get_fields().at(0).infix);
+ ASSERT_TRUE(collection->get_fields().at(0).sort);
+ ASSERT_EQ("en", collection->get_fields().at(0).locale);
+
delete collection;
}