Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Add test for eval expression validation.

Kishore Nallanf9bd328e4887
diff --git a/src/collection.cpp b/src/collection.cpp
index a35b2812..e05cea2c 100644
--- a/src/collection.cpp
+++ b/src/collection.cpp
@@ -681,6 +681,10 @@ Option<bool> Collection::validate_and_standardize_sort_fields(const std::vector<
const std::string& filter_exp = sort_field_std.name.substr(paran_start + 1,
sort_field_std.name.size() - paran_start -
2);
+ if(filter_exp.empty()) {
+ return Option<bool>(400, "The eval expression in sort_by is empty.");
+ }
+
Option<bool> parse_filter_op = filter::parse_filter_query(filter_exp, search_schema,
store, "", sort_field_std.eval.filter_tree_root);
if(!parse_filter_op.ok()) {
diff --git a/test/collection_sorting_test.cpp b/test/collection_sorting_test.cpp
index 80ffbaf5..afd678c1 100644
--- a/test/collection_sorting_test.cpp
+++ b/test/collection_sorting_test.cpp
@@ -2013,6 +2013,15 @@ TEST_F(CollectionSortingTest, OptionalFilteringViaSortingWildcard) {
ASSERT_FALSE(res_op.ok());
ASSERT_EQ("Error parsing eval expression in sort_by clause.", res_op.error());
+ // when eval condition is empty
+ sort_fields = {
+ sort_by("_eval()", "DESC"),
+ sort_by("points", "DESC"),
+ };
+ res_op = coll1->search("*", {"title"}, "", {}, sort_fields, {2}, 10, 1, FREQUENCY, {true}, 10);
+ ASSERT_FALSE(res_op.ok());
+ ASSERT_EQ("The eval expression in sort_by is empty.", res_op.error());
+
// more bad syntax!
sort_fields = {
sort_by(")", "DESC"),