Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences
C++ algoliadatastoreelasticsearchenterprise-searchfacetingfull-text-searchfuzzy-searchgeosearchin-memoryinstantsearchmerchandisingpineconesearchsearch-enginesemantic-searchsimilarity-searchsite-searchsynonymstypo-tolerancevector-search
fixing range facets
krunal1313fa4b20979e43
diff --git a/src/collection.cpp b/src/collection.cppindex 8cf0ebea..419c95d5 100644--- a/src/collection.cpp+++ b/src/collection.cpp@@ -4643,17 +4643,23 @@ Option<bool> Collection::parse_facet(const std::string& facet_field, std::vectorauto pos2 = range.find(",");auto pos3 = range.find("]");- int64_t lower_range, upper_range;-+ std::string lower_range, upper_range;+ auto lower_range_start = pos1 + 2;+ auto lower_range_len = pos2 - lower_range_start;+ auto upper_range_start = pos2 + 1;+ auto upper_range_len = pos3 - upper_range_start;+if(a_field.is_integer()) {- lower_range = std::stoll(range.substr(pos1 + 2, pos2));- upper_range = std::stoll(range.substr(pos2 + 1, pos3));+ lower_range = range.substr(lower_range_start, lower_range_len);+ StringUtils::trim(lower_range);+ upper_range = range.substr(upper_range_start, upper_range_len);+ StringUtils::trim(upper_range);} else {float val = std::stof(range.substr(pos1 + 2, pos2));- lower_range = Index::float_to_int64_t(val);+ lower_range = std::to_string(Index::float_to_int64_t(val));val = std::stof(range.substr(pos2 + 1, pos3));- upper_range = Index::float_to_int64_t(val);+ upper_range = std::to_string(Index::float_to_int64_t(val));}tupVec.emplace_back(std::make_tuple(lower_range, upper_range, range_val));diff --git a/test/collection_optimized_faceting_test.cpp b/test/collection_optimized_faceting_test.cppindex 7244d54e..972e1169 100644--- a/test/collection_optimized_faceting_test.cpp+++ b/test/collection_optimized_faceting_test.cpp@@ -860,7 +860,7 @@ TEST_F(CollectionOptimizedFacetingTest, RangeFacetTest) {"", true, 0UL, max_score, 100UL, 0UL, 4294967295UL, true);ASSERT_FALSE(rop.ok());- ASSERT_EQ("Range facet is restricted to only int32 and int64 fields.", rop.error());+ ASSERT_EQ("Range facet is restricted to only integer and float fields.", rop.error());// ensure that bad facet range values are handledrop = coll1->search("Karnataka", {"state"},