Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Add test for prefix search with filter.

Harpreet Sangarfc032efed3f4
diff --git a/src/art.cpp b/src/art.cpp
index 8c3b99ad..ee0fb53a 100644
--- a/src/art.cpp
+++ b/src/art.cpp
@@ -1031,7 +1031,7 @@ bool validate_and_add_leaf(art_leaf* leaf,
posting_t::merge({prev_leaf->values, leaf->values}, leaf_ids);
bool found = false;
- for (uint32_t i = 0; i < leaf_ids.size() && !found; i++) {
+ for (uint32_t i = 0; i < leaf_ids.size() && filter_result_iterator.is_valid && !found; i++) {
found = (filter_result_iterator.valid(leaf_ids[i]) == 1);
}
diff --git a/test/collection_filtering_test.cpp b/test/collection_filtering_test.cpp
index 1628c2dc..c644d547 100644
--- a/test/collection_filtering_test.cpp
+++ b/test/collection_filtering_test.cpp
@@ -2628,4 +2628,46 @@ TEST_F(CollectionFilteringTest, ComplexFilterQuery) {
}
collectionManager.drop_collection("ComplexFilterQueryCollection");
+}
+
+TEST_F(CollectionFilteringTest, PrefixSearchWithFilter) {
+ std::ifstream infile(std::string(ROOT_DIR)+"test/documents.jsonl");
+ std::vector<field> search_fields = {
+ field("title", field_types::STRING, false),
+ field("points", field_types::INT32, false)
+ };
+
+ query_fields = {"title"};
+ sort_fields = { sort_by(sort_field_const::text_match, "DESC"), sort_by("points", "DESC") };
+
+ auto collection = collectionManager.create_collection("collection", 4, search_fields, "points").get();
+
+ std::string json_line;
+
+ // dummy record for record id 0: to make the test record IDs to match with line numbers
+ json_line = "{\"points\":10,\"title\":\"z\"}";
+ collection->add(json_line);
+
+ while (std::getline(infile, json_line)) {
+ collection->add(json_line);
+ }
+
+ infile.close();
+
+ std::vector<std::string> facets;
+ auto results = collection->search("what ex", query_fields, "points: >10", facets, sort_fields, {0}, 10, 1, MAX_SCORE, {true}, 10,
+ spp::sparse_hash_set<std::string>(),
+ spp::sparse_hash_set<std::string>(), 10, "", 30, 5,
+ "", 10).get();
+ ASSERT_EQ(7, results["hits"].size());
+ std::vector<std::string> ids = {"6", "12", "19", "22", "13", "8", "15"};
+
+ for(size_t i = 0; i < results["hits"].size(); i++) {
+ nlohmann::json result = results["hits"].at(i);
+ std::string result_id = result["document"]["id"];
+ std::string id = ids.at(i);
+ ASSERT_STREQ(id.c_str(), result_id.c_str());
+ }
+
+ collectionManager.drop_collection("collection");
}
\ No newline at end of file