Skip to content

armgit / umami

Public Imported from GitHub
0

Umami is a privacy-first web and product analytics platform. Traffic, campaigns, behavior, conversions, and revenue in one place. No cookies, no surveillance, self-hosted or in the cloud.

fix(metrics): localize 'Unknown' label in tables

Alexander Klein306b555b96ad
diff --git a/components/metrics/CountriesTable.js b/components/metrics/CountriesTable.js
index 43ca374e9..a5c9c8011 100644
--- a/components/metrics/CountriesTable.js
+++ b/components/metrics/CountriesTable.js
@@ -10,7 +10,11 @@ export default function CountriesTable({ websiteId, onDataLoad, ...props }) {
const countryNames = useCountryNames(locale);
function renderLabel({ x }) {
- return <div className={locale}>{countryNames[x] ?? 'Unknown'}</div>;
+ return (
+ <div className={locale}>
+ {countryNames[x] ?? <FormattedMessage id="label.unknown" defaultMessage="Unknown" />}
+ </div>
+ );
}
return (
diff --git a/components/metrics/DataTable.js b/components/metrics/DataTable.js
index 2eff55199..d7e58cf7f 100644
--- a/components/metrics/DataTable.js
+++ b/components/metrics/DataTable.js
@@ -2,6 +2,7 @@ import React, { useState } from 'react';
import { FixedSizeList } from 'react-window';
import { useSpring, animated, config } from 'react-spring';
import classNames from 'classnames';
+import { FormattedMessage } from 'react-intl';
import NoData from 'components/common/NoData';
import { formatNumber, formatLongNumber } from 'lib/format';
import styles from './DataTable.module.css';
@@ -27,7 +28,11 @@ export default function DataTable({
return (
<AnimatedRow
key={label}
- label={renderLabel ? renderLabel(row) : label ?? 'Unknown'}
+ label={
+ renderLabel
+ ? renderLabel(row)
+ : label ?? <FormattedMessage id="label.unknown" defaultMessage="Unknown" />
+ }
value={value}
percent={percent}
animate={animate && !virtualize}