Skip to content

armgit / umami

Public Imported from GitHub
0

Umami is a privacy-first web and product analytics platform. Traffic, campaigns, behavior, conversions, and revenue in one place. No cookies, no surveillance, self-hosted or in the cloud.

fix(funnels): remove searchValue from ValueSelect queryKey to avoid unnecessary refetches

Rudy B.5246e2f3aa0b
diff --git a/src/app/(main)/websites/[websiteId]/(reports)/funnels/FunnelEditForm.tsx b/src/app/(main)/websites/[websiteId]/(reports)/funnels/FunnelEditForm.tsx
index 187a93542..2b5f7cdaf 100644
--- a/src/app/(main)/websites/[websiteId]/(reports)/funnels/FunnelEditForm.tsx
+++ b/src/app/(main)/websites/[websiteId]/(reports)/funnels/FunnelEditForm.tsx
@@ -115,15 +115,10 @@ function ValueSelect({
}) {
const { get, useQuery } = useApi();
const { formatMessage, messages } = useMessages();
- const [search, setSearch] = useState(value ?? '');
- const searchValue = useDebounce(search, 300);
const { startAt, endAt } = getEventDataDateRange();
const { data, isLoading } = useQuery<Array<{ value: string; total: number }>>({
- queryKey: [
- 'event-data:values',
- { websiteId, eventName, propertyName, searchValue, startAt, endAt },
- ],
+ queryKey: ['event-data:values', { websiteId, eventName, propertyName, startAt, endAt }],
queryFn: () =>
get(`/websites/${websiteId}/event-data/values`, {
startAt,
@@ -142,7 +137,6 @@ function ValueSelect({
items={values}
inputValue={value}
onInputChange={v => {
- setSearch(v);
onChange?.(v);
}}
formValue="text"