Skip to content

armgit / umami

Public Imported from GitHub
0

Umami is a privacy-first web and product analytics platform. Traffic, campaigns, behavior, conversions, and revenue in one place. No cookies, no surveillance, self-hosted or in the cloud.

Made FAVICON_URL a runtime variable. Closes #3412

Mike Cao6e6c1df858d6
diff --git a/src/app/actions/getConfig.ts b/src/app/actions/getConfig.ts
index bb892f01e..0b2e9273f 100644
--- a/src/app/actions/getConfig.ts
+++ b/src/app/actions/getConfig.ts
@@ -6,5 +6,6 @@ export async function getConfig() {
trackerScriptName: process.env.TRACKER_SCRIPT_NAME,
uiDisabled: !!process.env.DISABLE_UI,
updatesDisabled: !!process.env.DISABLE_UPDATES,
+ faviconUrl: process.env.FAVICON_URL,
};
}
diff --git a/src/components/common/Favicon.tsx b/src/components/common/Favicon.tsx
index c02fe74f9..50fb85e57 100644
--- a/src/components/common/Favicon.tsx
+++ b/src/components/common/Favicon.tsx
@@ -1,3 +1,4 @@
+import { useConfig } from '@/components/hooks';
import { FAVICON_URL, GROUPED_DOMAINS } from '@/lib/constants';
function getHostName(url: string) {
@@ -6,11 +7,13 @@ function getHostName(url: string) {
}
export function Favicon({ domain, ...props }) {
+ const config = useConfig();
+
if (process.env.privateMode) {
return null;
}
- const url = process.env.faviconURL || FAVICON_URL;
+ const url = config?.faviconURL || process.env.faviconURL || FAVICON_URL;
const hostName = domain ? getHostName(domain) : null;
const domainName = GROUPED_DOMAINS[hostName]?.domain || hostName;
const src = hostName ? url.replace(/\{\{\s*domain\s*}}/, domainName) : null;