Skip to content

armgit / umami

Public Imported from GitHub
0

Umami is a privacy-first web and product analytics platform. Traffic, campaigns, behavior, conversions, and revenue in one place. No cookies, no surveillance, self-hosted or in the cloud.

Fixed filter menu issue.

Mike Cao6ea48d5c2cfd
diff --git a/src/app/(main)/reports/[reportId]/FieldFilterEditForm.tsx b/src/app/(main)/reports/[reportId]/FieldFilterEditForm.tsx
index c1181e72c..7bb3ff122 100644
--- a/src/app/(main)/reports/[reportId]/FieldFilterEditForm.tsx
+++ b/src/app/(main)/reports/[reportId]/FieldFilterEditForm.tsx
@@ -105,9 +105,9 @@ export default function FieldFilterEditForm({
onChange({ name, type, operator, value: isEquals ? selected : value });
};
- const handleMenuSelect = (close: () => void, value: string) => {
+ const handleMenuSelect = (value: string) => {
setSelected(value);
- close();
+ setShowMenu(false);
};
const handleSearch = (value: string) => {
@@ -177,7 +177,7 @@ export default function FieldFilterEditForm({
values={filteredValues}
type={name}
isLoading={isLoading}
- onSelect={handleMenuSelect.bind(null, close)}
+ onSelect={handleMenuSelect}
/>
)}
</div>
@@ -202,7 +202,7 @@ const ResultsMenu = ({ values, type, isLoading, onSelect }) => {
const { formatValue } = useFormat();
if (isLoading) {
return (
- <Menu>
+ <Menu className={styles.menu} variant="popup">
<Item>
<Loading icon="dots" position="center" />
</Item>
@@ -216,7 +216,7 @@ const ResultsMenu = ({ values, type, isLoading, onSelect }) => {
return (
<Menu className={styles.menu} variant="popup" onSelect={onSelect}>
- {values?.map(value => {
+ {values?.map((value: any) => {
return <Item key={value}>{formatValue(value, type)}</Item>;
})}
</Menu>