Skip to content

armgit / umami

Public Imported from GitHub
0

Umami is a privacy-first web and product analytics platform. Traffic, campaigns, behavior, conversions, and revenue in one place. No cookies, no surveillance, self-hosted or in the cloud.

fix: creating a board without a description returns 500

brantsrasmus8d2938eddbfe
diff --git a/src/app/api/boards/route.ts b/src/app/api/boards/route.ts
index 252b6d697..86e4e246a 100644
--- a/src/app/api/boards/route.ts
+++ b/src/app/api/boards/route.ts
@@ -75,6 +75,9 @@ export async function POST(request: Request) {
...body,
type: normalizeBoardType(body.type),
id: uuid(),
+ // The column is NOT NULL with no default, so an omitted description —
+ // which the request schema allows — reaches Prisma as undefined and throws.
+ description: body.description ?? '',
parameters: body.parameters ?? {},
userId: !teamId ? auth.user.id : undefined,
};
diff --git a/tests/e2e/api-board.spec.ts b/tests/e2e/api-board.spec.ts
new file mode 100644
index 000000000..9bb0bb935
--- /dev/null
+++ b/tests/e2e/api-board.spec.ts
@@ -0,0 +1,35 @@
+import { expect, test } from '@playwright/test';
+import { type Auth, authHeaders, loginViaApi } from './helpers';
+
+test.describe('Board API tests', () => {
+ test.describe.configure({ mode: 'serial' });
+
+ let auth: Auth;
+ let boardId = '';
+
+ test.beforeAll(async ({ request }) => {
+ auth = await loginViaApi(request);
+ });
+
+ test.afterAll(async ({ request }) => {
+ if (boardId) {
+ await request.delete(`/api/boards/${boardId}`, { headers: authHeaders(auth) });
+ }
+ });
+
+ test('creates a board without a description', async ({ request }) => {
+ const response = await request.post('/api/boards', {
+ headers: authHeaders(auth),
+ data: { name: 'Playwright board', type: 'mixed' },
+ });
+
+ expect(response.status()).toBe(200);
+
+ const body = await response.json();
+
+ boardId = body.id;
+
+ expect(body).toHaveProperty('name', 'Playwright board');
+ expect(body).toHaveProperty('description', '');
+ });
+});