Umami is a privacy-first web and product analytics platform. Traffic, campaigns, behavior, conversions, and revenue in one place. No cookies, no surveillance, self-hosted or in the cloud.
TypeScript analyticsaudience-segmentationchartscohort-analysisgoogle-analyticsproduct-analyticsstatisticsuser-journeyweb-analytics
Update share form defaults to only select overview and events
Mike Caodd8888cfcfcb
diff --git a/src/app/(main)/websites/[websiteId]/settings/ShareCreateForm.tsx b/src/app/(main)/websites/[websiteId]/settings/ShareCreateForm.tsxindex 024fc10b7..a16f2dc54 100644--- a/src/app/(main)/websites/[websiteId]/settings/ShareCreateForm.tsx+++ b/src/app/(main)/websites/[websiteId]/settings/ShareCreateForm.tsx@@ -24,11 +24,11 @@ export function ShareCreateForm({ websiteId, onSave, onClose }: ShareCreateFormPconst { touch } = useModified();const [isPending, setIsPending] = useState(false);- // Build default values - all enabled by default+ // Build default values - only overview and events enabled by defaultconst defaultValues: Record<string, boolean> = {};SHARE_NAV_ITEMS.forEach(section => {section.items.forEach(item => {- defaultValues[item.id] = true;+ defaultValues[item.id] = item.id === 'overview' || item.id === 'events';});});@@ -38,7 +38,7 @@ export function ShareCreateForm({ websiteId, onSave, onClose }: ShareCreateFormPconst parameters: Record<string, boolean> = {};SHARE_NAV_ITEMS.forEach(section => {section.items.forEach(item => {- parameters[item.id] = data[item.id] ?? true;+ parameters[item.id] = data[item.id] ?? false;});});await post(`/websites/${websiteId}/shares`, { parameters });@@ -61,9 +61,7 @@ export function ShareCreateForm({ websiteId, onSave, onClose }: ShareCreateFormP<Column gap="1">{section.items.map(item => (<FormField key={item.id} name={item.id}>- <Checkbox>- <Text size="1">{formatMessage((labels as any)[item.label])}</Text>- </Checkbox>+ <Checkbox>{formatMessage((labels as any)[item.label])}</Checkbox></FormField>))}</Column>diff --git a/src/app/(main)/websites/[websiteId]/settings/ShareEditForm.tsx b/src/app/(main)/websites/[websiteId]/settings/ShareEditForm.tsxindex 5e8f8a74e..c5bd85a60 100644--- a/src/app/(main)/websites/[websiteId]/settings/ShareEditForm.tsx+++ b/src/app/(main)/websites/[websiteId]/settings/ShareEditForm.tsx@@ -57,7 +57,7 @@ export function ShareEditForm({const parameters: Record<string, boolean> = {};SHARE_NAV_ITEMS.forEach(section => {section.items.forEach(item => {- parameters[item.id] = data[item.id] ?? true;+ parameters[item.id] = data[item.id] ?? false;});});@@ -84,7 +84,8 @@ export function ShareEditForm({const defaultValues: Record<string, boolean> = {};SHARE_NAV_ITEMS.forEach(section => {section.items.forEach(item => {- defaultValues[item.id] = share?.parameters?.[item.id] ?? true;+ const defaultSelected = item.id === 'overview' || item.id === 'events';+ defaultValues[item.id] = share?.parameters?.[item.id] ?? defaultSelected;});});@@ -97,9 +98,7 @@ export function ShareEditForm({</Column>{SHARE_NAV_ITEMS.map(section => (<Column key={section.section} gap="1">- <Text size="2" weight="bold">- {formatMessage((labels as any)[section.section])}- </Text>+ <Text weight="bold">{formatMessage((labels as any)[section.section])}</Text><Column gap="1">{section.items.map(item => (<FormField key={item.id} name={item.id}>