Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix(formula): fix the issue where all formulas would be recalculated (#6364)

wpxp12345607485a2e7d68
diff --git a/packages/engine-formula/src/engine/dependency/formula-dependency.ts b/packages/engine-formula/src/engine/dependency/formula-dependency.ts
index 38320f7132..73efe23b80 100644
--- a/packages/engine-formula/src/engine/dependency/formula-dependency.ts
+++ b/packages/engine-formula/src/engine/dependency/formula-dependency.ts
@@ -585,6 +585,7 @@ export class FormulaDependencyGenerator extends Disposable {
if (treeId != null) {
FDtree.treeId = treeId;
FDtree.isCache = true;
+ this._dependencyManagerService.updateDependencyTreeDirtyState(treeId, false);
} else {
this._dependencyManagerService.addFormulaDependency(unitId, sheetId, row, column, FDtree);
this._dependencyManagerService.addFormulaDependencyByDefinedName(FDtree);
@@ -620,6 +621,7 @@ export class FormulaDependencyGenerator extends Disposable {
if (treeId != null) {
FDtree.treeId = treeId;
FDtree.isCache = true;
+ this._dependencyManagerService.updateDependencyTreeDirtyState(treeId, false);
} else {
this._dependencyManagerService.addFormulaDependency(unitId, sheetId, row, column, FDtree);
this._dependencyManagerService.addFormulaDependencyByDefinedName(FDtree);
diff --git a/packages/engine-formula/src/services/dependency-manager.service.ts b/packages/engine-formula/src/services/dependency-manager.service.ts
index 3d973c0e2f..7bf485490f 100644
--- a/packages/engine-formula/src/services/dependency-manager.service.ts
+++ b/packages/engine-formula/src/services/dependency-manager.service.ts
@@ -54,6 +54,8 @@ export interface IDependencyManagerService {
getAllTree(): IFormulaDependencyTree[];
buildDependencyTree(shouldBeBuildTrees: IFormulaDependencyTree[], dependencyTrees?: IFormulaDependencyTree[]): IFormulaDependencyTree[];
+
+ updateDependencyTreeDirtyState(treeId: number, isDirty: boolean): void;
}
export class DependencyManagerBaseService extends Disposable implements IDependencyManagerService {
@@ -213,6 +215,10 @@ export class DependencyManagerBaseService extends Disposable implements IDepende
this._addDefinedName(tree.unitId, definedName, treeId);
}
}
+
+ updateDependencyTreeDirtyState(treeId: number, isDirty: boolean): void {
+ throw new Error('Method not implemented.');
+ }
}
/**
@@ -652,6 +658,13 @@ export class DependencyManagerService extends DependencyManagerBaseService imple
protected override _addAllTreeMap(tree: IFormulaDependencyTree) {
this._allTreeMap.set(tree.treeId, tree);
}
+
+ override updateDependencyTreeDirtyState(treeId: number, isDirty: boolean): void {
+ const tree = this._allTreeMap.get(treeId);
+ if (tree) {
+ tree.isDirty = isDirty;
+ }
+ }
}
export const IDependencyManagerService = createIdentifier<DependencyManagerService>(