Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix(docs-drawing): formula ts error & docs-drawing load error (#2879)

zhangw1182bee68dc5
diff --git a/packages/docs-drawing-ui/src/controllers/doc-drawing-notification.controller.ts b/packages/docs-drawing-ui/src/controllers/doc-drawing-notification.controller.ts
index 1c62a2b620..cd7899a9f5 100644
--- a/packages/docs-drawing-ui/src/controllers/doc-drawing-notification.controller.ts
+++ b/packages/docs-drawing-ui/src/controllers/doc-drawing-notification.controller.ts
@@ -117,7 +117,7 @@ function getReOrderedDrawings(actions: JSONXActions): number[] {
return drawingIndexes;
}
-@OnLifecycle(LifecycleStages.Steady, DocDrawingAddRemoveController)
+@OnLifecycle(LifecycleStages.Ready, DocDrawingAddRemoveController)
export class DocDrawingAddRemoveController extends Disposable {
constructor(
@IUniverInstanceService private readonly _univerInstanceService: IUniverInstanceService,
@@ -144,8 +144,8 @@ export class DocDrawingAddRemoveController extends Disposable {
const params = command.params as IRichTextEditingMutationParams;
const { unitId, actions } = params;
- const addOrRemoveDrawings = getAddOrRemoveDrawings(actions);
+ const addOrRemoveDrawings = getAddOrRemoveDrawings(actions);
if (addOrRemoveDrawings != null) {
for (const { type, drawingId, drawing } of addOrRemoveDrawings) {
if (type === 'add') {
diff --git a/packages/docs-ui/src/docs-ui-plugin.ts b/packages/docs-ui/src/docs-ui-plugin.ts
index c1ab963c97..caaad363c4 100644
--- a/packages/docs-ui/src/docs-ui-plugin.ts
+++ b/packages/docs-ui/src/docs-ui-plugin.ts
@@ -79,12 +79,12 @@ export class UniverDocsUIPlugin extends Plugin {
override onReady(): void {
this._initRenderBasics();
+ this._markDocAsFocused();
}
override onRendered(): void {
this._initUI();
this._initRenderModules();
- this._markDocAsFocused();
}
private _initializeCommands(): void {
diff --git a/packages/engine-formula/src/functions/lookup/sort/index.ts b/packages/engine-formula/src/functions/lookup/sort/index.ts
index b9a402fda9..f2e5bf7877 100644
--- a/packages/engine-formula/src/functions/lookup/sort/index.ts
+++ b/packages/engine-formula/src/functions/lookup/sort/index.ts
@@ -45,7 +45,7 @@ export class Sort extends BaseFunction {
}
return byCol.map((byColObject) => {
- const result = this._handleSingleObject(array, sortIndex, sortOrder, byColObject);
+ const result = this._handleSingleObject(array, sortIndex!, sortOrder!, byColObject);
return result.isArray() ? (result as ArrayValueObject).get(0, 0) as BaseValueObject : result;
});
diff --git a/packages/engine-formula/src/functions/text/textsplit/index.ts b/packages/engine-formula/src/functions/text/textsplit/index.ts
index cff22d327c..a946a9a708 100644
--- a/packages/engine-formula/src/functions/text/textsplit/index.ts
+++ b/packages/engine-formula/src/functions/text/textsplit/index.ts
@@ -192,9 +192,9 @@ export class Textsplit extends BaseFunction {
return ErrorValueObject.create(ErrorType.VALUE);
}
- let padWithValue = padWith.getValue() as string;
+ let padWithValue = padWith!.getValue() as string;
- if (padWith.isBoolean()) {
+ if (padWith!.isBoolean()) {
padWithValue = padWithValue ? 'TRUE' : 'FALSE';
}