Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix(sheets-hyper-link-ui): hyper-link tooltip display far away of the cell bound (#5456)

WEI ZHANG12974daf6b2a
diff --git a/packages/sheets-ui/src/services/hover-manager.service.ts b/packages/sheets-ui/src/services/hover-manager.service.ts
index b348f44452..7142c4b3f4 100644
--- a/packages/sheets-ui/src/services/hover-manager.service.ts
+++ b/packages/sheets-ui/src/services/hover-manager.service.ts
@@ -300,6 +300,30 @@ export class HoverManagerService extends Disposable {
}
const rect = customRange?.rects.pop() ?? bullet?.rect ?? drawing?.rect;
+ const displayRect = rect && (() => {
+ const absoluteTop = rect.top + cell.mergeInfo.startY + topOffset;
+ const absoluteBottom = rect.bottom + cell.mergeInfo.startY + topOffset;
+ const absoluteLeft = rect.left + cell.mergeInfo.startX + leftOffset;
+ const absoluteRight = rect.right + cell.mergeInfo.startX + leftOffset;
+
+ const cellTop = cell.mergeInfo.startY + topOffset;
+ const cellBottom = cell.mergeInfo.endY + topOffset;
+ const cellLeft = cell.mergeInfo.startX + leftOffset;
+ const cellRight = cell.mergeInfo.endX + leftOffset;
+
+ const clampedTop = Math.min(Math.max(absoluteTop, cellTop), cellTop);
+ const clampedBottom = Math.min(absoluteBottom, cellBottom);
+ const clampedLeft = Math.min(Math.max(absoluteLeft, cellLeft), cellLeft);
+ const clampedRight = Math.min(absoluteRight, cellRight);
+
+ return {
+ top: clampedTop,
+ bottom: clampedBottom,
+ left: clampedLeft,
+ right: clampedRight,
+ };
+ })();
+
return {
location,
position,
@@ -307,12 +331,7 @@ export class HoverManagerService extends Disposable {
customRange: customRange?.range,
bullet: bullet?.paragraph,
drawing,
- rect: rect && {
- top: rect.top + cell.mergeInfo.startY + topOffset,
- bottom: rect.bottom + cell.mergeInfo.startY + topOffset,
- left: rect.left + cell.mergeInfo.startX + leftOffset,
- right: rect.right + cell.mergeInfo.startX + leftOffset,
- },
+ rect: displayRect,
};
}