Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.
TypeScript boardcollaborationdocdocxexceloffce365officepdfpptpptxpresentationsdksheetslidesspreadsheetuniverwordwordprocessorworkspacexlsx
fix(conditional-formatting): memory leak (#4212)
Gpound.liu1de083c588cd
diff --git a/e2e/visual-comparison/docs/docs-visual-comparison.spec.ts-snapshots/default-doc-ci-chromium-linux.png b/e2e/visual-comparison/docs/docs-visual-comparison.spec.ts-snapshots/default-doc-ci-chromium-linux.pngindex e91f38cdd2..e2284a2859 100644Binary files a/e2e/visual-comparison/docs/docs-visual-comparison.spec.ts-snapshots/default-doc-ci-chromium-linux.png and b/e2e/visual-comparison/docs/docs-visual-comparison.spec.ts-snapshots/default-doc-ci-chromium-linux.png differdiff --git a/packages/sheets-conditional-formatting/src/models/conditional-formatting-view-model.ts b/packages/sheets-conditional-formatting/src/models/conditional-formatting-view-model.tsindex a751baf9e9..6025d956d6 100644--- a/packages/sheets-conditional-formatting/src/models/conditional-formatting-view-model.ts+++ b/packages/sheets-conditional-formatting/src/models/conditional-formatting-view-model.ts@@ -132,7 +132,7 @@ export class ConditionalFormattingViewModel extends Disposable {*/public markRuleDirty = (() => {const rxItem = new Subject<{ unitId: string; subUnitId: string; cfId: string; isNeedResetPreComputingCache: boolean }>();- rxItem.pipe(bufferTime(100), filter((e) => !!e.length), map((list) => {+ this.disposeWithMe(rxItem.pipe(bufferTime(100), filter((e) => !!e.length), map((list) => {const set = new Set();const result: typeof list = [];list.forEach((item) => {@@ -152,7 +152,7 @@ export class ConditionalFormattingViewModel extends Disposable {list.forEach((item) => {this._markRuleDirtyAtOnce(item.unitId, item.subUnitId, item.cfId, item.isNeedResetPreComputingCache);});- });+ }));return (unitId: string, subUnitId: string, cfId: string, isNeedResetPreComputingCache: boolean = true) => {rxItem.next({ unitId, subUnitId, cfId, isNeedResetPreComputingCache });};