Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.
TypeScript boardcollaborationdocdocxexceloffce365officepdfpptpptxpresentationsdksheetslidesspreadsheetuniverwordwordprocessorworkspacexlsx
feat(docs-ui): optimize doc menu scroller (#4909)
ZhangWei20772c3de2f2
diff --git a/packages/design/src/components/side-menu/index.tsx b/packages/design/src/components/side-menu/index.tsxindex ff1d349934..f02fccf29e 100644--- a/packages/design/src/components/side-menu/index.tsx+++ b/packages/design/src/components/side-menu/index.tsx@@ -31,7 +31,7 @@ export interface ISideMenuProps {className?: string;style?: React.CSSProperties;mode?: 'float' | 'side-bar';- maxHeight?: string;+ maxHeight: number;activeId?: string;open?: boolean;onOpenChange?: (open: boolean) => void;@@ -62,10 +62,25 @@ export const SideMenu = forwardRef<ISideMenuInstance, ISideMenuProps>((props, rescrollTo: (id: string) => {if (!menusRef.current) return;const index = menusRef.current.findIndex((menu) => menu.id === id);- if (index === -1) return;+ if (index === -1 || !containerRef.current) return;++ // Find the actual DOM element by its ID+ const targetElement = document.getElementById(`univer-side-menu-${id}`);+ if (!targetElement) return;++ // Get the element's offsetTop relative to its parent+ const targetTop = targetElement.offsetTop;++ // Get container's scrollable height+ const containerHeight = containerRef.current.clientHeight;+ const maxScrollTop = containerRef.current.scrollHeight - containerHeight;++ // Calculate the scroll position to center the element if possible+ const scrollPosition = Math.max(0, Math.min(targetTop - containerHeight / 2 + targetElement.clientHeight / 2, maxScrollTop));+containerRef.current?.scrollTo({behavior: 'smooth',- top: 32 * index,+ top: scrollPosition,});},}), []);diff --git a/packages/design/src/components/side-menu/side-menu.stories.tsx b/packages/design/src/components/side-menu/side-menu.stories.tsxindex fb3bc3db9c..68ab528694 100644--- a/packages/design/src/components/side-menu/side-menu.stories.tsx+++ b/packages/design/src/components/side-menu/side-menu.stories.tsx@@ -48,7 +48,7 @@ export const SideMenuBasic = {return (<SideMenu- maxHeight="150px"+ maxHeight={150}menus={menus}onClick={handleClick}open={open}@@ -61,7 +61,7 @@ export const SideMenuBasic = {export const EmptySideMenu = {render() {- return <SideMenu />;+ return <SideMenu maxHeight={150} />;},};@@ -79,7 +79,7 @@ export const CustomStyledSideMenu = {borderRadius: '4px',};- return <SideMenu menus={menus} className="custom-side-menu" style={customStyle} />;+ return <SideMenu maxHeight={150} menus={menus} className="custom-side-menu" style={customStyle} />;},};@@ -98,6 +98,6 @@ export const MultiLevelSideMenu = {const handleClick = (_menu: ISideMenuItem) => {};- return <SideMenu menus={menus} onClick={handleClick} />;+ return <SideMenu maxHeight={150} menus={menus} onClick={handleClick} />;},};diff --git a/packages/docs-ui/src/views/side-menu/index.tsx b/packages/docs-ui/src/views/side-menu/index.tsxindex 59082b2734..86fa6e1536 100644--- a/packages/docs-ui/src/views/side-menu/index.tsx+++ b/packages/docs-ui/src/views/side-menu/index.tsx@@ -173,7 +173,9 @@ export function DocSideMenu() {}return (- <div className="univer-absolute univer-bottom-0 univer-left-0 univer-top-0 univer-z-[100] univer-w-[0px]">+ <div+ className="univer-absolute univer-bottom-0 univer-left-0 univer-top-0 univer-z-[100] univer-w-[0px]"+ ><SideMenumenus={menus}open={open}@@ -183,7 +185,7 @@ export function DocSideMenu() {wrapperClass="univer-mt-12"activeId={activeId}onClick={handleClick}- maxHeight={`${canvasHeight - 48}px`}+ maxHeight={canvasHeight - 48}/></div>);