Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix: fix the issue with custom formulas in conditional formatting introduced in version 0.12.3 (#6431)

wpxp123456239bba0abfb9
diff --git a/packages/engine-formula/src/engine/reference-object/base-reference-object.ts b/packages/engine-formula/src/engine/reference-object/base-reference-object.ts
index 2995966862..d905326b83 100644
--- a/packages/engine-formula/src/engine/reference-object/base-reference-object.ts
+++ b/packages/engine-formula/src/engine/reference-object/base-reference-object.ts
@@ -124,31 +124,25 @@ export class BaseReferenceObject extends ObjectClassType {
getRangePosition() {
const { x, y } = this.getRefOffset();
- const rangeData = this.getRangeData();
- let { startRow, startColumn, endRow, endColumn } = moveRangeByOffset(rangeData, x, y);
+ const newRange = moveRangeByOffset(this.getRangeData(), x, y);
- if (Number.isNaN(startRow)) {
- startRow = 0;
+ if (Number.isNaN(newRange.startRow)) {
+ newRange.startRow = 0;
}
- if (Number.isNaN(startColumn)) {
- startColumn = 0;
+ if (Number.isNaN(newRange.startColumn)) {
+ newRange.startColumn = 0;
}
- if (Number.isNaN(endRow)) {
- endRow = this.getActiveSheetRowCount() - 1;
+ if (Number.isNaN(newRange.endRow)) {
+ newRange.endRow = this.getActiveSheetRowCount() - 1;
}
- if (Number.isNaN(endColumn)) {
- endColumn = this.getActiveSheetColumnCount() - 1;
+ if (Number.isNaN(newRange.endColumn)) {
+ newRange.endColumn = this.getActiveSheetColumnCount() - 1;
}
- return {
- startRow,
- endRow,
- startColumn,
- endColumn,
- };
+ return newRange;
}
override isReferenceObject() {