Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix(design): ensure colorpicker trigger onChanged callback on mouseup event (#4443)

白熱32f1d309e9fa
diff --git a/packages/design/src/components/color-picker/ColorSpectrum.tsx b/packages/design/src/components/color-picker/ColorSpectrum.tsx
index ba4836b04a..4d2077fcf2 100644
--- a/packages/design/src/components/color-picker/ColorSpectrum.tsx
+++ b/packages/design/src/components/color-picker/ColorSpectrum.tsx
@@ -62,17 +62,21 @@ export function ColorSpectrum({ hsv, onChange, onChanged }: IColorSpectrumProps)
onChange(hsv[0], s, v);
};
- const handlePointerUp = useCallback((e: MouseEvent) => {
- if (isDragging) {
- onChanged?.(hsv[0], hsv[1], hsv[2]);
- }
+ const handlePointerUp = useCallback(() => {
setIsDragging(false);
}, [hsv]);
+ function handleChange() {
+ onChanged?.(hsv[0], hsv[1], hsv[2]);
+ }
+
useEffect(() => {
+ containerRef.current?.addEventListener('mouseup', handleChange);
window.addEventListener('pointerup', handlePointerUp);
window.addEventListener('mouseup', handlePointerUp);
+
return () => {
+ containerRef.current?.removeEventListener('mouseup', handleChange);
window.removeEventListener('pointerup', handlePointerUp);
window.removeEventListener('mouseup', handlePointerUp);
};