Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.
TypeScript boardcollaborationdocdocxexceloffce365officepdfpptpptxpresentationsdksheetslidesspreadsheetuniverwordwordprocessorworkspacexlsx
fix(formula): row range calculation error (#2649)
Univer3dcedc224703
diff --git a/packages/engine-formula/src/engine/analysis/__tests__/parser.spec.ts b/packages/engine-formula/src/engine/analysis/__tests__/parser.spec.tsindex 6b2d219b4b..0058a59aa5 100644--- a/packages/engine-formula/src/engine/analysis/__tests__/parser.spec.ts+++ b/packages/engine-formula/src/engine/analysis/__tests__/parser.spec.ts@@ -194,5 +194,15 @@ describe('Test indirect', () => {expect((result as BaseValueObject).getValue()).toStrictEqual(ErrorType.NAME);});++ it('Reference row', async () => {+ const lexerNode = lexer.treeBuilder('=SUM(1:1)');++ const astNode = astTreeBuilder.parse(lexerNode as LexerNode);++ const result = interpreter.execute(astNode as BaseAstNode);++ expect((result as BaseValueObject).getValue()).toStrictEqual(3);+ });});});diff --git a/packages/engine-formula/src/engine/ast-node/function-node.ts b/packages/engine-formula/src/engine/ast-node/function-node.tsindex 2d8ff084fd..3aa06f085d 100644--- a/packages/engine-formula/src/engine/ast-node/function-node.ts+++ b/packages/engine-formula/src/engine/ast-node/function-node.ts@@ -34,6 +34,7 @@ import { ArrayValueObject, transformToValueObject, ValueObjectFactory } from '..import { type BaseValueObject, ErrorValueObject } from '../value-object/base-value-object';import { prefixHandler } from '../utils/prefixHandler';import { IDefinedNamesService } from '../../services/defined-names.service';+import { matchToken } from '../../basics/token';import { BaseAstNode, ErrorNode } from './base-ast-node';import { BaseAstNodeFactory, DEFAULT_AST_NODE_FACTORY_Z_INDEX } from './base-ast-node-factory';import { NODE_ORDER_MAP, NodeType } from './node-type';@@ -301,7 +302,7 @@ export class FunctionNodeFactory extends BaseAstNodeFactory {const { tokenTrim, minusPrefixNode, atPrefixNode } = prefixHandler(token.trim(), this._functionService, this._injector);- if (!Number.isNaN(Number(tokenTrim))) {+ if (!Number.isNaN(Number(tokenTrim)) && !this._isParentUnionNode(param)) {return ErrorNode.create(ErrorType.VALUE);}@@ -319,4 +320,8 @@ export class FunctionNodeFactory extends BaseAstNodeFactory {return functionNode;}}++ private _isParentUnionNode(param: LexerNode) {+ return param.getParent()?.getParent()?.getToken() === matchToken.COLON;+ }}