Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

chore(core): add rev methods on unit models (#3454)

Wenzhao Hu4033a24909ed
diff --git a/packages/core/src/common/unit.ts b/packages/core/src/common/unit.ts
index ac1c9d125a..a2c3b63280 100644
--- a/packages/core/src/common/unit.ts
+++ b/packages/core/src/common/unit.ts
@@ -37,4 +37,8 @@ export abstract class UnitModel<D = object, T extends UnitType = UnitType> exten
/** Get revision of the unit's snapshot. Note that revision should start from 1. */
abstract getRev(): number;
+ /** Increment the current revision. */
+ abstract incrementRev(): void;
+ /** Set revision of the current snapshot. */
+ abstract setRev(rev: number): void;
}
diff --git a/packages/core/src/docs/data-model/document-data-model.ts b/packages/core/src/docs/data-model/document-data-model.ts
index 7ae520eaf6..c1673d9f09 100644
--- a/packages/core/src/docs/data-model/document-data-model.ts
+++ b/packages/core/src/docs/data-model/document-data-model.ts
@@ -64,14 +64,18 @@ class DocumentDataModelSimple extends UnitModel<IDocumentData, UniverInstanceTyp
this._name$.next(this.snapshot.title ?? 'No Title');
}
- getRev(): number {
+ override getRev(): number {
return this.snapshot.rev ?? 1;
}
- incrementRev(): void {
+ override incrementRev(): void {
this.snapshot.rev = this.getRev() + 1;
}
+ override setRev(rev: number): void {
+ this.snapshot.rev = rev;
+ }
+
setName(name: string) {
this.snapshot.title = name;
this._name$.next(name);
diff --git a/packages/core/src/sheets/workbook.ts b/packages/core/src/sheets/workbook.ts
index a95848805c..86fbaddfb3 100644
--- a/packages/core/src/sheets/workbook.ts
+++ b/packages/core/src/sheets/workbook.ts
@@ -152,14 +152,18 @@ export class Workbook extends UnitModel<IWorkbookData, UniverInstanceType.UNIVER
return this._unitId;
}
- getRev(): number {
+ override getRev(): number {
return this._snapshot.rev ?? 1; // the revision number should start with one
}
- incrementRev(): void {
+ override incrementRev(): void {
this._snapshot.rev = this.getRev() + 1;
}
+ override setRev(rev: number): void {
+ this._snapshot.rev = rev;
+ }
+
/**
* Add a Worksheet into Workbook.
*/
diff --git a/packages/core/src/slides/slide-model.ts b/packages/core/src/slides/slide-model.ts
index 7708abb2a9..b076da9365 100644
--- a/packages/core/src/slides/slide-model.ts
+++ b/packages/core/src/slides/slide-model.ts
@@ -65,10 +65,18 @@ export class SlideDataModel extends UnitModel<ISlideData, UniverInstanceType.UNI
this._unitId = this._snapshot.id ?? generateRandomId(6);
}
- getRev(): number {
+ override getRev(): number {
return 0; // TODO@jikkai: slide has not implement collaborative editing yet
}
+ override incrementRev(): void {
+ // do nothing
+ }
+
+ override setRev(_rev: number): void {
+ // do nothing
+ }
+
getSnapshot() {
return this._snapshot;
}