Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

refactor(permission): remove history record management permission point (#6784)

wpxp12345652e87ce621c0
diff --git a/packages/sheets/src/facade/permission/permission-point-map.ts b/packages/sheets/src/facade/permission/permission-point-map.ts
index 7f67884514..b3d1c7182a 100644
--- a/packages/sheets/src/facade/permission/permission-point-map.ts
+++ b/packages/sheets/src/facade/permission/permission-point-map.ts
@@ -32,7 +32,6 @@ import {
WorkbookEditablePermission,
WorkbookExportPermission,
WorkbookHideSheetPermission,
- WorkbookHistoryPermission,
WorkbookInsertColumnPermission,
WorkbookInsertRowPermission,
WorkbookManageCollaboratorPermission,
@@ -85,7 +84,6 @@ export const WORKBOOK_PERMISSION_POINT_MAP: Record<WorkbookPermissionPoint, Work
[WorkbookPermissionPoint.MoveSheet]: WorkbookMoveSheetPermission,
[WorkbookPermissionPoint.HideSheet]: WorkbookHideSheetPermission,
[WorkbookPermissionPoint.ViewHistory]: WorkbookViewHistoryPermission,
- [WorkbookPermissionPoint.ManageHistory]: WorkbookHistoryPermission,
[WorkbookPermissionPoint.RecoverHistory]: WorkbookRecoverHistoryPermission,
[WorkbookPermissionPoint.CreateProtection]: WorkbookCreateProtectPermission,
[WorkbookPermissionPoint.InsertRow]: WorkbookInsertRowPermission,
diff --git a/packages/sheets/src/facade/permission/permission-types.ts b/packages/sheets/src/facade/permission/permission-types.ts
index bfde3deebd..a801a56092 100644
--- a/packages/sheets/src/facade/permission/permission-types.ts
+++ b/packages/sheets/src/facade/permission/permission-types.ts
@@ -88,8 +88,6 @@ export enum WorkbookPermissionPoint {
HideSheet = 'WorkbookHideSheet',
/** View history permission */
ViewHistory = 'WorkbookViewHistory',
- /** Manage history permission */
- ManageHistory = 'WorkbookHistory',
/** Recover history permission */
RecoverHistory = 'WorkbookRecoverHistory',
/** Create protection permission */
diff --git a/packages/sheets/src/index.ts b/packages/sheets/src/index.ts
index fec5b9cedc..54fe45f9d4 100644
--- a/packages/sheets/src/index.ts
+++ b/packages/sheets/src/index.ts
@@ -385,7 +385,6 @@ export {
WorkbookEditablePermission,
WorkbookExportPermission,
WorkbookHideSheetPermission,
- WorkbookHistoryPermission,
WorkbookManageCollaboratorPermission,
WorkbookMoveSheetPermission,
WorkbookPrintPermission,
diff --git a/packages/sheets/src/services/permission/permission-point/const.ts b/packages/sheets/src/services/permission/permission-point/const.ts
index 88ab654468..253d22452f 100644
--- a/packages/sheets/src/services/permission/permission-point/const.ts
+++ b/packages/sheets/src/services/permission/permission-point/const.ts
@@ -25,7 +25,6 @@ import { WorkbookDuplicatePermission } from './workbook/duplicate';
import { WorkbookEditablePermission } from './workbook/editable';
import { WorkbookExportPermission } from './workbook/export';
import { WorkbookHideSheetPermission } from './workbook/hide-sheet';
-import { WorkbookHistoryPermission } from './workbook/history';
import { WorkbookManageCollaboratorPermission } from './workbook/manage-collaborator';
import { WorkbookMoveSheetPermission } from './workbook/move-sheet';
import { WorkbookPrintPermission } from './workbook/print';
@@ -102,11 +101,6 @@ export const PermissionPointsDefinitions = {
*/
WorkbookHideSheetPermission,
- /**
- * The permission point for viewing and managing workbook history
- */
- WorkbookHistoryPermission,
-
/**
* The permission point for managing collaborators in a workbook
*/
diff --git a/packages/sheets/src/services/permission/permission-point/index.ts b/packages/sheets/src/services/permission/permission-point/index.ts
index 6bffdec3bc..d3cf19918b 100644
--- a/packages/sheets/src/services/permission/permission-point/index.ts
+++ b/packages/sheets/src/services/permission/permission-point/index.ts
@@ -28,7 +28,6 @@ export { WorkbookDuplicatePermission } from './workbook/duplicate';
export { WorkbookEditablePermission } from './workbook/editable';
export { WorkbookExportPermission } from './workbook/export';
export { WorkbookHideSheetPermission } from './workbook/hide-sheet';
-export { WorkbookHistoryPermission } from './workbook/history';
export { WorkbookInsertColumnPermission } from './workbook/insert-column';
export { WorkbookInsertRowPermission } from './workbook/insert-row';
export { WorkbookManageCollaboratorPermission } from './workbook/manage-collaborator';
@@ -38,7 +37,6 @@ export { WorkbookRecoverHistoryPermission } from './workbook/recover-history';
export { WorkbookRenameSheetPermission } from './workbook/rename-sheet';
export { WorkbookSharePermission } from './workbook/share';
export { WorkbookViewPermission } from './workbook/view';
-
export { WorkbookViewHistoryPermission } from './workbook/view-history';
export { WorksheetCopyPermission } from './worksheet/copy';
export { WorksheetDeleteColumnPermission } from './worksheet/delete-column';
diff --git a/packages/sheets/src/services/permission/permission-point/workbook/history.ts b/packages/sheets/src/services/permission/permission-point/workbook/history.ts
deleted file mode 100644
index 5f407b2e92..0000000000
--- a/packages/sheets/src/services/permission/permission-point/workbook/history.ts
+++ /dev/null
@@ -1,32 +0,0 @@
-/**
- * Copyright 2023-present DreamNum Co., Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import type { IPermissionPoint } from '@univerjs/core';
-import { PermissionStatus } from '@univerjs/core';
-import { UnitAction, UnitObject } from '@univerjs/protocol';
-
-export class WorkbookHistoryPermission implements IPermissionPoint {
- id: string;
- value = true;
- type = UnitObject.Workbook;
- status = PermissionStatus.INIT;
- subType = UnitAction.History;
-
- constructor(public unitId: string) {
- this.unitId = unitId;
- this.id = `${this.type}.${UnitAction.History}_${unitId}`;
- }
-}