Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix: uni drawing update (#3016)

zhangw607e4008bb16
diff --git a/packages/docs-drawing-ui/src/controllers/doc-drawing-transformer-update.controller.ts b/packages/docs-drawing-ui/src/controllers/doc-drawing-transformer-update.controller.ts
index ac73d6b4b0..eaaeb1ec1f 100644
--- a/packages/docs-drawing-ui/src/controllers/doc-drawing-transformer-update.controller.ts
+++ b/packages/docs-drawing-ui/src/controllers/doc-drawing-transformer-update.controller.ts
@@ -154,11 +154,12 @@ export class DocDrawingTransformerController extends Disposable {
if (objects.size > 1) {
throttleMultipleDrawingUpdate(objects);
} else if (objects.size === 1) {
- const drawingCache: IDrawingCache = this._transformerCache.values().next().value;
+ const drawingCache: Nullable<IDrawingCache> = this._transformerCache.values().next().value;
const object: BaseObject = objects.values().next().value;
const { width, height, top, left, angle } = object;
if (
+ drawingCache &&
width === drawingCache.width &&
height === drawingCache.height &&
top === drawingCache.top &&
@@ -183,6 +184,7 @@ export class DocDrawingTransformerController extends Disposable {
// Handle transformer mouseup.
this.disposeWithMe(
toDisposable(
+ // eslint-disable-next-line complexity
transformer.changeEnd$.subscribe((state) => {
const { objects, offsetX, offsetY } = state;
@@ -206,11 +208,12 @@ export class DocDrawingTransformerController extends Disposable {
if (objects.size > 1) {
this._updateMultipleDrawingDocTransform(objects);
} else if (objects.size === 1) {
- const drawingCache: IDrawingCache = this._transformerCache.values().next().value;
+ const drawingCache: Nullable<IDrawingCache> = this._transformerCache.values().next().value;
const object: BaseObject = objects.values().next().value;
const { width, height, top, left, angle } = object;
if (
+ drawingCache &&
width === drawingCache.width &&
height === drawingCache.height &&
top === drawingCache.top &&
diff --git a/packages/sheets-drawing-ui/src/controllers/sheet-drawing-update.controller.ts b/packages/sheets-drawing-ui/src/controllers/sheet-drawing-update.controller.ts
index 7a06d3a93d..91dd62e371 100644
--- a/packages/sheets-drawing-ui/src/controllers/sheet-drawing-update.controller.ts
+++ b/packages/sheets-drawing-ui/src/controllers/sheet-drawing-update.controller.ts
@@ -298,7 +298,7 @@ export class SheetDrawingUpdateController extends Disposable implements IRenderM
// const imageDrawing = this._drawingManagerService.getDrawingByParam({ unitId, subUnitId, drawingId });
- if (sheetDrawing == null) {
+ if (sheetDrawing == null || sheetDrawing.unitId !== this._context.unitId) {
return;
}