Skip to content

Build your own AI office with Univer Office SDK. Bring editing, calculation, collaboration, and file processing into your product for people and AI agents. Built on an extensible open-source core.

fix(sheets-drawing-ui): error delete cache when float-dom hide (#2540)

zhangwb1dc036efd18
diff --git a/packages/sheets-drawing-ui/src/services/canvas-float-dom-manager.service.ts b/packages/sheets-drawing-ui/src/services/canvas-float-dom-manager.service.ts
index 8de4d1a8e2..5bb46986dd 100644
--- a/packages/sheets-drawing-ui/src/services/canvas-float-dom-manager.service.ts
+++ b/packages/sheets-drawing-ui/src/services/canvas-float-dom-manager.service.ts
@@ -473,9 +473,8 @@ export class SheetCanvasFloatDomManagerService extends Disposable {
return;
}
const { unitId, subUnitId } = info;
- const map = this._ensureMap(unitId, subUnitId);
this._domLayerInfoMap.delete(id);
- map.delete(id);
+
info.dispose.dispose();
const renderObject = this._getSceneAndTransformerByDrawingSearch(unitId);
if (renderObject) {
@@ -483,6 +482,8 @@ export class SheetCanvasFloatDomManagerService extends Disposable {
}
if (removeDrawing) {
+ const map = this._ensureMap(unitId, subUnitId);
+ map.delete(id);
const param = this._drawingManagerService.getDrawingByParam({ unitId, subUnitId, drawingId: id });
if (!param) {
return;